OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix possible bug when no args have been provided to the executable 

Hi,

This bug is related to:

  <https://sourceware.org/ml/gdb-patches/2017-06/msg00216.html>

On stringify_argv, we have to check if args[0] is not NULL before
stringifying anything, otherwise we might do the wrong thing when
trimming the "ret" string in the end.  args[0] will be NULL when no
arguments are passed to the inferior that will be started.

Checked in as obvious.

gdb/ChangeLog:
2017-06-08  Sergio Durigan Junior  <sergiodj@redhat.com>

	* common/common-utils.c (stringify_argv): Check for "arg[0] !=
	NULL".
This commit is contained in:
Sergio Durigan Junior 2017-06-08 16:58:25 -04:00
parent e3d1d4088a
commit 2f91880f3a
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2017-06-08 Sergio Durigan Junior <sergiodj@redhat.com>
* common/common-utils.c (stringify_argv): Check for "arg[0] !=
NULL".
2017-06-08 Alan Hayward <alan.hayward@arm.com>
* mn10300-tdep.c (MN10300_MAX_REGISTER_SIZE): Add.

2
gdb/common/common-utils.c
View File

@ -337,7 +337,7 @@ stringify_argv (const std::vector<char *> &args)
{
std::string ret;
if (!args.empty ())
if (!args.empty () && args[0] != NULL)
{
for (auto s : args)
if (s != NULL)