Code cleanup: Rename enum -> enum filterflags
Bit mask ints are better to make enums as GDB already has support to automatically decode them: before this patch: (gdb) p filterflags $1 = 51 (gdb) p/x filterflags $2 = 0x33 after this patch: (gdb) p filterflags $1 = (COREFILTER_ANON_PRIVATE | COREFILTER_ANON_SHARED | COREFILTER_ELF_HEADERS | COREFILTER_HUGETLB_PRIVATE) gdb/ChangeLog 2015-06-15 Jan Kratochvil <jan.kratochvil@redhat.com> * linux-tdep.c (enum filterflags): Make it from anonymous enum. (dump_mapping_p): Use it for parameter filterflags. (linux_find_memory_regions_full): Use it for variable filterflags.
This commit is contained in:
parent
909c2cdaa7
commit
31b7833d20
|
@ -1,3 +1,9 @@
|
||||||
|
2015-06-15 Jan Kratochvil <jan.kratochvil@redhat.com>
|
||||||
|
|
||||||
|
* linux-tdep.c (enum filterflags): Make it from anonymous enum.
|
||||||
|
(dump_mapping_p): Use it for parameter filterflags.
|
||||||
|
(linux_find_memory_regions_full): Use it for variable filterflags.
|
||||||
|
|
||||||
2015-06-15 Aleksandar Ristovski <aristovski@qnx.com
|
2015-06-15 Aleksandar Ristovski <aristovski@qnx.com
|
||||||
Jan Kratochvil <jan.kratochvil@redhat.com>
|
Jan Kratochvil <jan.kratochvil@redhat.com>
|
||||||
|
|
||||||
|
|
|
@ -46,7 +46,7 @@
|
||||||
Documentation/filesystems/proc.txt, inside the Linux kernel
|
Documentation/filesystems/proc.txt, inside the Linux kernel
|
||||||
tree. */
|
tree. */
|
||||||
|
|
||||||
enum
|
enum filterflags
|
||||||
{
|
{
|
||||||
COREFILTER_ANON_PRIVATE = 1 << 0,
|
COREFILTER_ANON_PRIVATE = 1 << 0,
|
||||||
COREFILTER_ANON_SHARED = 1 << 1,
|
COREFILTER_ANON_SHARED = 1 << 1,
|
||||||
|
@ -598,7 +598,7 @@ mapping_is_anonymous_p (const char *filename)
|
||||||
This should work OK enough, however. */
|
This should work OK enough, however. */
|
||||||
|
|
||||||
static int
|
static int
|
||||||
dump_mapping_p (unsigned int filterflags, const struct smaps_vmflags *v,
|
dump_mapping_p (enum filterflags filterflags, const struct smaps_vmflags *v,
|
||||||
int maybe_private_p, int mapping_anon_p, int mapping_file_p,
|
int maybe_private_p, int mapping_anon_p, int mapping_file_p,
|
||||||
const char *filename)
|
const char *filename)
|
||||||
{
|
{
|
||||||
|
@ -1119,10 +1119,10 @@ linux_find_memory_regions_full (struct gdbarch *gdbarch,
|
||||||
/* Default dump behavior of coredump_filter (0x33), according to
|
/* Default dump behavior of coredump_filter (0x33), according to
|
||||||
Documentation/filesystems/proc.txt from the Linux kernel
|
Documentation/filesystems/proc.txt from the Linux kernel
|
||||||
tree. */
|
tree. */
|
||||||
unsigned int filterflags = (COREFILTER_ANON_PRIVATE
|
enum filterflags filterflags = (COREFILTER_ANON_PRIVATE
|
||||||
| COREFILTER_ANON_SHARED
|
| COREFILTER_ANON_SHARED
|
||||||
| COREFILTER_ELF_HEADERS
|
| COREFILTER_ELF_HEADERS
|
||||||
| COREFILTER_HUGETLB_PRIVATE);
|
| COREFILTER_HUGETLB_PRIVATE);
|
||||||
|
|
||||||
/* We need to know the real target PID to access /proc. */
|
/* We need to know the real target PID to access /proc. */
|
||||||
if (current_inferior ()->fake_pid_p)
|
if (current_inferior ()->fake_pid_p)
|
||||||
|
|
Loading…
Reference in New Issue