OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

x86: Check pseudo prefix without instruction 

Pseudo prefixes must be used on an instruction.  Issue an error when
pseudo prefix is used without instruction.

	PR gas/22623
	* gas/config/tc-i386.c (output_insn): Check pseudo prefix
	without instruction.
	* testsuite/gas/i386/i386.exp: Run inval-pseudo.
	* testsuite/gas/i386/inval-pseudo.l: New file.
	* testsuite/gas/i386/inval-pseudo.s: Likewise.
This commit is contained in:
H.J. Lu 2017-12-17 09:40:54 -08:00
parent fd7055f4a7
commit 390c91cfcf
5 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gas/ChangeLog
View File

@ -1,3 +1,12 @@
2017-12-17 H.J. Lu <hongjiu.lu@intel.com>
PR gas/22623
* gas/config/tc-i386.c (output_insn): Check pseudo prefix
without instruction.
* testsuite/gas/i386/i386.exp: Run inval-pseudo.
* testsuite/gas/i386/inval-pseudo.l: New file.
* testsuite/gas/i386/inval-pseudo.s: Likewise.
2017-12-15 Jan Beulich <jbeulich@suse.com>
* config/tc-i386.c (match_template): Add missing ! to

6
gas/config/tc-i386.c
View File

@ -7258,6 +7258,12 @@ check_prefix:
break;
case 1:
break;
case 0:
/* Check for pseudo prefixes. */
as_bad_where (insn_start_frag->fr_file,
insn_start_frag->fr_line,
_("pseudo prefix without instruction"));
return;
default:
abort ();
}

1
gas/testsuite/gas/i386/i386.exp
View File

@ -429,6 +429,7 @@ if [expr ([istarget "i*86-*-*"] || [istarget "x86_64-*-*"]) && [gas_32_check]]
run_list_test "notrackbad" "-al"
run_dump_test "align-1a"
run_dump_test "align-1b"
run_list_test "inval-pseudo" "-al"
# These tests require support for 8 and 16 bit relocs,
# so we only run them for ELF and COFF targets.

11
gas/testsuite/gas/i386/inval-pseudo.l Normal file
View File

@ -0,0 +1,11 @@
.*: Assembler messages:
.*:3: Error: .*
GAS LISTING .*
[ ]*1[ ]+\.text
[ ]*2[ ]+\?\?\?\? 90 nop
[ ]*3[ ]+\{disp32\}
[ ]*4[ ]+\?\?\?\? 90 nop
[ ]*5[ ]+\?\?\?\? 00000000 \.p2align 4,0
#...

5
gas/testsuite/gas/i386/inval-pseudo.s Normal file
View File

@ -0,0 +1,5 @@
.text
nop
{disp32}
nop
.p2align 4,0