OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix memory allocation and release problems in the bfd documentation processor.

Browse Source 
* doc/chew.c (add_to_definition): Use correct type when
	calculating size of array reallocation.
	(nextword): Always initialise the word return parameter.
	(compile): Check return value of nextword().
This commit is contained in:
Tim R?hsen 2019-11-05 16:03:07 +00:00 committed by Nick Clifton
parent 7abb8d8111
commit 3a70f7e8e3
2 changed files with 25 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
bfd/ChangeLog
View File

@ -1,3 +1,10 @@
2019-11-05 Tim Rühsen <tim.ruehsen@gmx.de>
* doc/chew.c (add_to_definition): Use correct type when
calculating size of array reallocation.
(nextword): Always initialise the word return parameter.
(compile): Check return value of nextword().
2019-10-30 Keith Seitz <keiths@redhat.com>
* elf-bfd.h (elf_backend_data) <elf_backend_core_find_build_id>:

24
bfd/doc/chew.c
View File

@ -1167,7 +1167,10 @@ nextword (string, word)
}
}
if (!*string)
return 0;
{
*word = NULL;
return NULL;
}
word_start = string;
if (*string == '"')
@ -1225,7 +1228,7 @@ nextword (string, word)
if (*string)
return string + 1;
else
return 0;
return NULL;
}
dict_type *root;
@ -1243,7 +1246,7 @@ lookup_word (word)
}
if (warning)
fprintf (stderr, "Can't find %s\n", word);
return 0;
return NULL;
}
static void
@ -1276,7 +1279,7 @@ free_words (void)
}
static void
perform ()
perform (void)
{
tos = stack;
@ -1333,7 +1336,7 @@ add_to_definition (entry, word)
entry->code_length += 2;
entry->code =
(stinst_type *) realloc ((char *) (entry->code),
entry->code_length * sizeof (word_type));
entry->code_length * sizeof (stinst_type));
}
entry->code[entry->code_end] = word;
@ -1374,6 +1377,8 @@ compile (string)
{
free (word);
string = nextword (string, &word);
if (!string)
continue;
add_var (word);
string = nextword (string, &word);
}
@ -1384,8 +1389,16 @@ compile (string)
/* Compile a word and add to dictionary. */
free (word);
string = nextword (string, &word);
if (!string)
continue;
ptr = newentry (word);
string = nextword (string, &word);
if (!string)
{
free (ptr->code);
free (ptr);
continue;
}
while (word[0] != ';')
{
@ -1423,7 +1436,6 @@ compile (string)
}
add_to_definition (ptr, 0);
free (word);
word = NULL;
string = nextword (string, &word);
}
else