OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update some comments on stap-probe.c 

Some functions's comments were not entirely correct on stap-probe.c,
so this patch updates them.

Pushed as obvious.

gdb/ChangeLog:
2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>

	* stap-probe.c (stap_get_opcode): Update comment.
	(stap_get_expected_argument_type): Likewise.
	(handle_stap_probe): Likewise.
This commit is contained in:
Sergio Durigan Junior 2019-05-16 16:11:20 -04:00
parent af2d9beee9
commit 3ca58cdea1
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
* stap-probe.c (stap_get_opcode): Update comment.
(stap_get_expected_argument_type): Likewise.
(handle_stap_probe): Likewise.
2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com> 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
* i386-tdep.c (i386_stap_parse_special_token_triplet): Change * i386-tdep.c (i386_stap_parse_special_token_triplet): Change

13
gdb/stap-probe.c
View File

@ -316,8 +316,9 @@ stap_get_operator_prec (enum exp_opcode op)
} }
} }
/* Given S, read the operator in it and fills the OP pointer with its code. /* Given S, read the operator in it. Return the EXP_OPCODE which
Return 1 on success, zero if the operator was not recognized. */ represents the operator detected, or throw an error if no operator
was found. */
static enum exp_opcode static enum exp_opcode
stap_get_opcode (const char **s) stap_get_opcode (const char **s)
@ -422,7 +423,8 @@ stap_get_opcode (const char **s)
} }
/* Given the bitness of the argument, represented by B, return the /* Given the bitness of the argument, represented by B, return the
corresponding `struct type *'. */ corresponding `struct type *', or throw an error if B is
unknown. */
static struct type * static struct type *
stap_get_expected_argument_type (struct gdbarch *gdbarch, stap_get_expected_argument_type (struct gdbarch *gdbarch,
@ -1491,10 +1493,7 @@ stap_probe::gen_info_probes_table_values () const
probe doesn't have an associated semaphore; probe doesn't have an associated semaphore;
- Probe's provider name; - Probe's provider name;
- Probe's name; - Probe's name;
- Probe's argument format - Probe's argument format. */
This function returns 1 if the handling was successful, and zero
otherwise. */
static void static void
handle_stap_probe (struct objfile *objfile, struct sdt_note *el, handle_stap_probe (struct objfile *objfile, struct sdt_note *el,