Slightly simplify minsym creation

Only one caller of minimal_symbol_reader::record_with_info was using
the return value, so this patch simplifies this code by having it
return void and changing that caller to use record_full instead.

gdb/ChangeLog
2019-03-15  Tom Tromey  <tom@tromey.com>

	* minsyms.h (class minimal_symbol_reader) <record_with_info>:
	Don't return the symbol.
	* coffread.c (record_minimal_symbol): Use record_full.
This commit is contained in:
Tom Tromey 2019-03-01 17:37:30 -07:00
parent 2219ae0b0e
commit 3db066bcd5
3 changed files with 15 additions and 7 deletions

View File

@ -1,3 +1,9 @@
2019-03-15 Tom Tromey <tom@tromey.com>
* minsyms.h (class minimal_symbol_reader) <record_with_info>:
Don't return the symbol.
* coffread.c (record_minimal_symbol): Use record_full.
2019-03-14 Eli Zaretskii <eliz@gnu.org>
The MS-Windows port of ncurses fails to switch to a color pair if

View File

@ -463,7 +463,8 @@ record_minimal_symbol (minimal_symbol_reader &reader,
return NULL;
}
return reader.record_with_info (cs->c_name, address, type, section);
return reader.record_full (cs->c_name, strlen (cs->c_name), true, address,
type, section);
}
/* coff_symfile_init ()

View File

@ -116,14 +116,15 @@ class minimal_symbol_reader
/* Like record_full, but:
- uses strlen to compute NAME_LEN,
- passes COPY_NAME = true. */
- passes COPY_NAME = true.
struct minimal_symbol *record_with_info (const char *name,
CORE_ADDR address,
enum minimal_symbol_type ms_type,
int section)
This variant does not return the new symbol. */
void record_with_info (const char *name, CORE_ADDR address,
enum minimal_symbol_type ms_type,
int section)
{
return record_full (name, strlen (name), true, address, ms_type, section);
record_full (name, strlen (name), true, address, ms_type, section);
}
private: