OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Aarch64 SVE: Fix stack smashing when calling functions

Browse Source 
Using "call" on a function that passes arguments via float registers can cause
gdb to overflow buffers.

Ensure enough memory is reserved to hold a full FP register.

This fixes gdb.base/callfuncs.exp for Aarch64 SVE.

2018-09-18  Alan Hayward  <alan.hayward@arm.com>

	* aarch64-tdep.c (pass_in_v): Use register size.
	(aarch64_extract_return_value): Likewise.
	(aarch64_store_return_value): Likewise.
This commit is contained in:
Alan Hayward 2018-09-17 15:28:53 +01:00
parent af81c43b51
commit 3ff2c72e14
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2018-09-18 Alan Hayward <alan.hayward@arm.com>
* aarch64-tdep.c (pass_in_v): Use register size.
(aarch64_extract_return_value): Likewise.
(aarch64_store_return_value): Likewise.
2018-09-18 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
* utils.c (dump_core) [HAVE_SETRLIMIT]: Cast RLIM_INFINITY to

12
gdb/aarch64-tdep.c
View File

@ -1366,7 +1366,9 @@ pass_in_v (struct gdbarch *gdbarch,
if (info->nsrn < 8)
{
int regnum = AARCH64_V0_REGNUM + info->nsrn;
gdb_byte reg[V_REGISTER_SIZE];
/* Enough space for a full vector register. */
gdb_byte reg[register_size (gdbarch, regnum)];
gdb_assert (len <= sizeof (reg));
info->argnum++;
info->nsrn++;
@ -1937,7 +1939,9 @@ aarch64_extract_return_value (struct type *type, struct regcache *regs,
for (int i = 0; i < elements; i++)
{
int regno = AARCH64_V0_REGNUM + i;
bfd_byte buf[V_REGISTER_SIZE];
/* Enough space for a full vector register. */
gdb_byte buf[register_size (gdbarch, regno)];
gdb_assert (len <= sizeof (buf));
if (aarch64_debug)
{
@ -2047,7 +2051,9 @@ aarch64_store_return_value (struct type *type, struct regcache *regs,
for (int i = 0; i < elements; i++)
{
int regno = AARCH64_V0_REGNUM + i;
bfd_byte tmpbuf[V_REGISTER_SIZE];
/* Enough space for a full vector register. */
gdb_byte tmpbuf[register_size (gdbarch, regno)];
gdb_assert (len <= sizeof (tmpbuf));
if (aarch64_debug)
{