OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Re: bfd_cleanup for object_p

Browse Source 
I hate files that you can't compile.

	* cisco-core.c (cisco_core_file_p): Return bfd_cleanup.
	* hpux-core.c (hpux_core_core_file_p): Update prototype.
	* sco5-core.c (sco5_core_file_p): Return bfd_cleanup.
	(core_sco5_vec): Correct initialisers.
This commit is contained in:
Alan Modra 2020-03-03 00:08:42 +10:30
parent 601b73d500
commit 40b35c78b6
4 changed files with 23 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
bfd/ChangeLog
View File

@ -1,3 +1,10 @@
2020-03-02 Alan Modra <amodra@gmail.com>
* cisco-core.c (cisco_core_file_p): Return bfd_cleanup.
* hpux-core.c (hpux_core_core_file_p): Update prototype.
* sco5-core.c (sco5_core_file_p): Return bfd_cleanup.
(core_sco5_vec): Correct initialisers.
2020-03-02 Alan Modra <amodra@gmail.com> 2020-03-02 Alan Modra <amodra@gmail.com>
* aix386-core.c (aix386_core_file_p): Return bfd_cleanup. * aix386-core.c (aix386_core_file_p): Return bfd_cleanup.

10
bfd/cisco-core.c
View File

@ -286,19 +286,19 @@ cisco_core_file_validate (bfd *abfd, int crash_info_loc)
return NULL; return NULL;
} }
static const bfd_target * static bfd_cleanup
cisco_core_file_p (bfd *abfd) cisco_core_file_p (bfd *abfd)
{ {
int *crash_info_locp; int *crash_info_locp;
const bfd_target *target = NULL; bfd_cleanup cleanup = NULL;
for (crash_info_locp = crash_info_locs; for (crash_info_locp = crash_info_locs;
*crash_info_locp != -1 && target == NULL; *crash_info_locp != -1 && cleanup == NULL;
crash_info_locp++) crash_info_locp++)
{ {
target = cisco_core_file_validate (abfd, *crash_info_locp); cleanup = cisco_core_file_validate (abfd, *crash_info_locp);
} }
return (target); return cleanup;
} }
static char * static char *

2
bfd/hpux-core.c
View File

@ -106,7 +106,7 @@ struct hpux_core_struct
static asection *make_bfd_asection (bfd *, const char *, flagword, static asection *make_bfd_asection (bfd *, const char *, flagword,
bfd_size_type, bfd_vma, unsigned int); bfd_size_type, bfd_vma, unsigned int);
static const bfd_target *hpux_core_core_file_p (bfd *); static bfd_cleanup hpux_core_core_file_p (bfd *);
static char *hpux_core_core_file_failing_command (bfd *); static char *hpux_core_core_file_failing_command (bfd *);
static int hpux_core_core_file_failing_signal (bfd *); static int hpux_core_core_file_failing_signal (bfd *);
static void swap_abort (void); static void swap_abort (void);

16
bfd/sco5-core.c
View File

@ -101,7 +101,7 @@ read_uarea (bfd *abfd, int filepos)
return &rawptr->u; return &rawptr->u;
} }
const bfd_cleanup bfd_cleanup
sco5_core_file_p (bfd *abfd) sco5_core_file_p (bfd *abfd)
{ {
int coffset_siz, val, nsecs, cheadoffs; int coffset_siz, val, nsecs, cheadoffs;
@ -172,7 +172,7 @@ sco5_core_file_p (bfd *abfd)
(file_ptr) coffsets.u_stack)) (file_ptr) coffsets.u_stack))
goto fail; goto fail;
return abfd->xvec; /* Done for version 1 */ return _bfd_no_cleanup; /* Done for version 1 */
} }
/* Immediately before coreoffsets region is a long with offset in core /* Immediately before coreoffsets region is a long with offset in core
@ -372,12 +372,16 @@ const bfd_target core_sco5_vec =
sco5_core_file_p /* a core file */ sco5_core_file_p /* a core file */
}, },
{ /* bfd_set_format */ { /* bfd_set_format */
_bfd_bool_bfd_false_error, bfd_false, _bfd_bool_bfd_false_error,
_bfd_bool_bfd_false_error, bfd_false _bfd_bool_bfd_false_error,
_bfd_bool_bfd_false_error,
_bfd_bool_bfd_false_error
}, },
{ /* bfd_write_contents */ { /* bfd_write_contents */
_bfd_bool_bfd_false_error, bfd_false, _bfd_bool_bfd_false_error,
_bfd_bool_bfd_false_error, bfd_false _bfd_bool_bfd_false_error,
_bfd_bool_bfd_false_error,
_bfd_bool_bfd_false_error
}, },
BFD_JUMP_TABLE_GENERIC (_bfd_generic), BFD_JUMP_TABLE_GENERIC (_bfd_generic),