OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gdb/csky: Use default gdbarch methods where possible 

Make use of the default gdbarch methods for gdbarch_dummy_id,
gdbarch_unwind_pc, and gdbarch_unwind_sp where possible.

I have not tested this change but, by inspecting the code, I believe
the default methods are equivalent to the code being deleted.

gdb/ChangeLog:

	* gdb/csky-tdep.c (csky_dummy_id): Delete.
	(csky_unwind_pc): Delete.
	(csky_unwind_sp): Delete.
	(csky_gdbarch_init): Don't register deleted functions with
	gdbarch.
This commit is contained in:
Andrew Burgess 2018-12-19 22:18:28 +00:00
parent 8010f57641
commit 4133e5a13f
2 changed files with 8 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/ChangeLog
View File

@ -1,3 +1,11 @@
2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
* gdb/csky-tdep.c (csky_dummy_id): Delete.
(csky_unwind_pc): Delete.
(csky_unwind_sp): Delete.
(csky_gdbarch_init): Don't register deleted functions with
gdbarch.
2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
* gdb/cris-tdep.c (cris_dummy_id): Delete.

34
gdb/csky-tdep.c
View File

@ -160,14 +160,6 @@ csky_write_pc (regcache *regcache, CORE_ADDR val)
regcache_cooked_write_unsigned (regcache, CSKY_PC_REGNUM, val);
}
/* Implement the unwind_sp gdbarch method. */
static CORE_ADDR
csky_unwind_sp (struct gdbarch *gdbarch, struct frame_info *next_frame)
{
return frame_unwind_register_unsigned (next_frame, CSKY_SP_REGNUM);
}
/* C-Sky ABI register names. */
static const char *csky_register_names[] =
@ -1883,14 +1875,6 @@ csky_frame_unwind_cache (struct frame_info *this_frame)
return cache;
}
/* Implement the unwind_pc gdbarch method. */
static CORE_ADDR
csky_unwind_pc (struct gdbarch *gdbarch, struct frame_info *next_frame)
{
return frame_unwind_register_unsigned (next_frame, CSKY_PC_REGNUM);
}
/* Implement the this_id function for the normal unwinder. */
static void
@ -2045,19 +2029,6 @@ static const struct frame_base csky_frame_base = {
csky_frame_base_address
};
/* Implement the dummy_id gdbarch method. The frame ID's base
needs to match the TOS value saved by save_dummy_frame_tos,
and the PC should match the dummy frame's breakpoint. */
static struct frame_id
csky_dummy_id (struct gdbarch *gdbarch, struct frame_info *this_frame)
{
unsigned int sp_regnum = CSKY_SP_REGNUM;
CORE_ADDR sp = get_frame_register_unsigned (this_frame, sp_regnum);
return frame_id_build (sp, get_frame_pc (this_frame));
}
/* Initialize register access method. */
static void
@ -2245,13 +2216,8 @@ csky_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
set_gdbarch_frame_align (gdbarch, csky_frame_align);
set_gdbarch_stack_frame_destroyed_p (gdbarch, csky_stack_frame_destroyed_p);
/* Functions to access frame data. */
set_gdbarch_unwind_pc (gdbarch, csky_unwind_pc);
set_gdbarch_unwind_sp (gdbarch, csky_unwind_sp);
/* Functions handling dummy frames. */
set_gdbarch_push_dummy_call (gdbarch, csky_push_dummy_call);
set_gdbarch_dummy_id (gdbarch, csky_dummy_id);
/* Frame unwinders. Use DWARF debug info if available,
otherwise use our own unwinder. */