OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sim: fix minor --sysroot mem leak

Browse Source 
The current --sysroot parsing attempts to keep from leaking memory by
treating the empty string specially (sine this is the initial value),
but it ends up leaking memory when the arg is an empty string.  So if
someone uses --sysroot "", the old value is leaked, as is the new one.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
This commit is contained in:
Mike Frysinger 2011-05-27 18:05:16 +00:00
parent 432b4d03ad
commit 440db57552
2 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sim/common/ChangeLog
View File

@ -1,3 +1,9 @@
2011-05-27 Mike Frysinger <vapier@gentoo.org>
* sim-options.c (standard_option_handler): Remove arg[0] check
when freeing simulator_sysroot. Only strdup arg when arg[0] is
not an empty string, otherwise assign "" back to it.
2011-05-26 Mike Frysinger <vapier@gentoo.org>
* nltvals.def: Regenerate to include Blackfin syscalls again.

10
sim/common/sim-options.c
View File

@ -458,10 +458,14 @@ standard_option_handler (SIM_DESC sd, sim_cpu *cpu, int opt,
case OPTION_SYSROOT:
/* Don't leak memory in the odd event that there's lots of
--sysroot=... options. */
if (simulator_sysroot[0] != '\0' && arg[0] != '\0')
--sysroot=... options. We treat "" specially since this
is the statically initialized value and cannot free it. */
if (simulator_sysroot[0] != '\0')
free (simulator_sysroot);
simulator_sysroot = xstrdup (arg);
if (arg[0] != '\0')
simulator_sysroot = xstrdup (arg);
else
simulator_sysroot = "";
break;
}