From 44c62d9e249963c9e9c0e2b658c8bf50d90237fc Mon Sep 17 00:00:00 2001 From: Michael Snyder Date: Thu, 26 Jul 2007 18:43:24 +0000 Subject: [PATCH] 2007-07-26 Michael Snyder * coffgen.c (_bfd_coff_read_internal_relocs): If internal_relocs are not to be cached, free the temporary buffer. --- bfd/ChangeLog | 3 +++ bfd/coffgen.c | 21 +++++++++++++-------- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 4fd7f4aa3b..54ef404bc3 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,5 +1,8 @@ 2007-07-26 Michael Snyder + * coffgen.c (_bfd_coff_read_internal_relocs): If internal_relocs + are not to be cached, free the temporary buffer. + * aoutx.h (slurp_reloc_table): Return TRUE if reloc_size == zero or count == zero. diff --git a/bfd/coffgen.c b/bfd/coffgen.c index f4f97b3f0d..7fad78c78f 100644 --- a/bfd/coffgen.c +++ b/bfd/coffgen.c @@ -457,17 +457,22 @@ _bfd_coff_read_internal_relocs (bfd *abfd, free_external = NULL; } - if (cache && free_internal != NULL) + if (free_internal != NULL) { - if (coff_section_data (abfd, sec) == NULL) + if (cache) + free (free_internal); + else { - amt = sizeof (struct coff_section_tdata); - sec->used_by_bfd = bfd_zalloc (abfd, amt); - if (sec->used_by_bfd == NULL) - goto error_return; - coff_section_data (abfd, sec)->contents = NULL; + if (coff_section_data (abfd, sec) == NULL) + { + amt = sizeof (struct coff_section_tdata); + sec->used_by_bfd = bfd_zalloc (abfd, amt); + if (sec->used_by_bfd == NULL) + goto error_return; + coff_section_data (abfd, sec)->contents = NULL; + } + coff_section_data (abfd, sec)->relocs = free_internal; } - coff_section_data (abfd, sec)->relocs = free_internal; } return internal_relocs;