OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[gdb/testsuite] Fix exec_is_pie with gold linker 

When running test-case gdb.base/break-interp.exp with target board gold, we
run into:
...
gdb compile failed, pie failed to generate PIE executable
...

The problem is that the proc exec_is_pie uses the PIE flag in the readelf -d
output, which doesn't seem to be set by the gold linker.

Instead, use the "Type" field in the readelf -h output.

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2020-05-25  Tom de Vries  <tdevries@suse.de>

	PR testsuite/26031
	* lib/gdb.exp (exec_is_pie): Test readelf -h output.
This commit is contained in:
Tom de Vries 2020-05-25 12:01:52 +02:00
parent 3c5a0e025b
commit 465e1b0f19
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2020-05-25 Tom de Vries <tdevries@suse.de>
PR testsuite/26031
* lib/gdb.exp (exec_is_pie): Test readelf -h output.
2020-05-25 Tom de Vries <tdevries@suse.de>
* boards/gold.exp: New file.

5
gdb/testsuite/lib/gdb.exp
View File

@ -5509,11 +5509,12 @@ proc exec_is_pie { executable } {
return -1
}
set readelf_program [gdb_find_readelf]
set res [catch {exec $readelf_program -d $executable} output]
set res [catch {exec $readelf_program -h $executable} output]
if { $res != 0 } {
return -1
}
set res [regexp -line {\(FLAGS_1\).*Flags:.* PIE($| )} $output]
set res [regexp -line {^[ \t]*Type:[ \t]*DYN \(Shared object file\)$} \
$output]
if { $res == 1 } {
return 1
}