OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

2012-12-05 Pedro Alves <pedro@codesourcery.com> 

* amd64-linux-nat.c (amd64_linux_dr_get): Remove FIXME comment.
	Reinstate perror_with_name call on ptrace error.  Remove #if 0.
	* i386-linux-nat.c (i386_linux_dr_get): Likewise.
	* i386bsd-nat.c (i386bsd_dr_get_status): Likewise.
This commit is contained in:
Pedro Alves 2011-12-05 14:16:50 +00:00
parent 73017762b2
commit 482950ed19
4 changed files with 7 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2012-12-05 Pedro Alves <pedro@codesourcery.com>
* amd64-linux-nat.c (amd64_linux_dr_get): Remove FIXME comment.
Reinstate perror_with_name call on ptrace error. Remove #if 0.
* i386-linux-nat.c (i386_linux_dr_get): Likewise.
* i386bsd-nat.c (i386bsd_dr_get_status): Likewise.
2011-12-05 Andrey Smirnov <andrew.smirnov@gmail.com>
* breakpoint.c (init_breakpoint_sal): Remove nested definitions of

9
gdb/amd64-linux-nat.c
View File

@ -277,20 +277,11 @@ amd64_linux_dr_get (ptid_t ptid, int regnum)
if (tid == 0)
tid = PIDGET (ptid);
/* FIXME: kettenis/2001-03-27: Calling perror_with_name if the
ptrace call fails breaks debugging remote targets. The correct
way to fix this is to add the hardware breakpoint and watchpoint
stuff to the target vector. For now, just return zero if the
ptrace call fails. */
errno = 0;
value = ptrace (PTRACE_PEEKUSER, tid,
offsetof (struct user, u_debugreg[regnum]), 0);
if (errno != 0)
#if 0
perror_with_name (_("Couldn't read debug register"));
#else
return 0;
#endif
return value;
}

9
gdb/i386-linux-nat.c
View File

@ -665,20 +665,11 @@ i386_linux_dr_get (ptid_t ptid, int regnum)
if (tid == 0)
tid = PIDGET (ptid);
/* FIXME: kettenis/2001-03-27: Calling perror_with_name if the
ptrace call fails breaks debugging remote targets. The correct
way to fix this is to add the hardware breakpoint and watchpoint
stuff to the target vector. For now, just return zero if the
ptrace call fails. */
errno = 0;
value = ptrace (PTRACE_PEEKUSER, tid,
offsetof (struct user, u_debugreg[regnum]), 0);
if (errno != 0)
#if 0
perror_with_name (_("Couldn't read debug register"));
#else
return 0;
#endif
return value;
}

9
gdb/i386bsd-nat.c
View File

@ -312,18 +312,9 @@ i386bsd_dr_get_status (void)
{
struct dbreg dbregs;
/* FIXME: kettenis/2001-03-31: Calling perror_with_name if the
ptrace call fails breaks debugging remote targets. The correct
way to fix this is to add the hardware breakpoint and watchpoint
stuff to the target vector. For now, just return zero if the
ptrace call fails. */
if (ptrace (PT_GETDBREGS, PIDGET (inferior_ptid),
(PTRACE_TYPE_ARG3) &dbregs, 0) == -1)
#if 0
perror_with_name (_("Couldn't read debug registers"));
#else
return 0;
#endif
return DBREG_DRX ((&dbregs), 6);
}