gdb: Small cleanup to disasm.c:maybe_add_dis_line_entry

Give the function a better name (drop "maybe_") and update the header
comment.

gdb/ChangeLog:

	* disasm.c (maybe_add_dis_line_entry): Rename to...
	(add_dis_line_entry): ...this, and update header comment.
	(do_mixed_source_and_assembly): Now use add_dis_line_entry.
This commit is contained in:
Andrew Burgess 2016-01-21 12:56:25 +01:00
parent a994041db3
commit 4a099de2e7
2 changed files with 9 additions and 4 deletions

View File

@ -1,3 +1,9 @@
2016-01-21 Andrew Burgess <andrew.burgess@embecosm.com>
* disasm.c (maybe_add_dis_line_entry): Rename to...
(add_dis_line_entry): ...this, and update header comment.
(do_mixed_source_and_assembly): Now use add_dis_line_entry.
2016-01-21 Pedro Alves <palves@redhat.com>
* Makefile.in (COMPILER_CFLAGS): New.

View File

@ -86,11 +86,10 @@ allocate_dis_line_table (void)
xfree, xcalloc, xfree);
}
/* Add DLE to TABLE.
Returns 1 if added, 0 if already present. */
/* Add a new dis_line_entry containing SYMTAB and LINE to TABLE. */
static void
maybe_add_dis_line_entry (htab_t table, struct symtab *symtab, int line)
add_dis_line_entry (htab_t table, struct symtab *symtab, int line)
{
void **slot;
struct dis_line_entry dle, *dlep;
@ -552,7 +551,7 @@ do_mixed_source_and_assembly (struct gdbarch *gdbarch, struct ui_out *uiout,
pc += length;
if (sal.symtab != NULL)
maybe_add_dis_line_entry (dis_line_table, sal.symtab, sal.line);
add_dis_line_entry (dis_line_table, sal.symtab, sal.line);
}
/* Second pass: print the disassembly.