OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix uninitialised ARM data 

MALLOC_PERTURB_=1 results in "FAIL: PIC" on arm-vxworks, due to garbage
in words with got relocs.

	* config/tc-arm.c (s_arm_elf_cons): Initialise after frag_more.
	(md_apply_fix): Delete now unnecessary zeroing for BFD_RELOC_ARM_GOT*
	and BFD_RELOC_ARM_TLS* relocs.  Simplify BFD_RELOC_8 case.
This commit is contained in:
Alan Modra 2014-06-16 09:56:29 +09:30
parent 44ed9ef26f
commit 4b1a927e92
2 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gas/ChangeLog
View File

@ -1,3 +1,9 @@
2014-06-16 Alan Modra <amodra@gmail.com>
* config/tc-arm.c (s_arm_elf_cons): Initialise after frag_more.
(md_apply_fix): Delete now unnecessary zeroing for BFD_RELOC_ARM_GOT*
and BFD_RELOC_ARM_TLS* relocs. Simplify BFD_RELOC_8 case.
2014-06-16 Alan Modra <amodra@gmail.com>
* config/tc-cris.c (md_create_long_jump): Follow "short" jump

12
gas/config/tc-arm.c
View File

@ -3453,7 +3453,8 @@ s_arm_elf_cons (int nbytes)
memcpy (base, save_buf, p - base);
offset = nbytes - size;
p = frag_more ((int) nbytes);
p = frag_more (nbytes);
memset (p, 0, nbytes);
fix_new_exp (frag_now, p - frag_now->fr_literal + offset,
size, &exp, 0, (enum bfd_reloc_code_real) reloc);
}
@ -22384,7 +22385,7 @@ md_apply_fix (fixS * fixP,
case BFD_RELOC_8:
if (fixP->fx_done || !seg->use_rela_p)
md_number_to_chars (buf, value, 1);
*buf = value;
break;
case BFD_RELOC_16:
@ -22397,9 +22398,6 @@ md_apply_fix (fixS * fixP,
case BFD_RELOC_ARM_THM_TLS_CALL:
case BFD_RELOC_ARM_TLS_DESCSEQ:
case BFD_RELOC_ARM_THM_TLS_DESCSEQ:
S_SET_THREAD_LOCAL (fixP->fx_addsy);
break;
case BFD_RELOC_ARM_TLS_GOTDESC:
case BFD_RELOC_ARM_TLS_GD32:
case BFD_RELOC_ARM_TLS_LE32:
@ -22407,12 +22405,10 @@ md_apply_fix (fixS * fixP,
case BFD_RELOC_ARM_TLS_LDM32:
case BFD_RELOC_ARM_TLS_LDO32:
S_SET_THREAD_LOCAL (fixP->fx_addsy);
/* fall through */
break;
case BFD_RELOC_ARM_GOT32:
case BFD_RELOC_ARM_GOTOFF:
if (fixP->fx_done || !seg->use_rela_p)
md_number_to_chars (buf, 0, 4);
break;
case BFD_RELOC_ARM_GOT_PREL: