OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove unneeded checks on type lengths. 

Type lengths are unsigned, so they are always greater than or equal to
zero.  A check against the length of 'tgt_type' is retained to prevent
dividing by zero.

gdb/ChangeLog:

	* v850-tdep.c (v850_use_struct_convention): Trim type length checks.
This commit is contained in:
John Baldwin 2016-06-11 13:10:48 -07:00
parent 683cd65eb4
commit 4bf5402d91
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ChangeLog
View File

@ -1,3 +1,7 @@
2016-06-14 John Baldwin <jhb@FreeBSD.org>
* v850-tdep.c (v850_use_struct_convention): Trim type length checks.
2016-06-14 John Baldwin <jhb@FreeBSD.org>
* tui/tui-stack.c (tui_show_frame_info): Fix type mismatch.

2
gdb/v850-tdep.c
View File

@ -559,7 +559,7 @@ v850_use_struct_convention (struct gdbarch *gdbarch, struct type *type)
if (TYPE_CODE (fld_type) == TYPE_CODE_ARRAY)
{
tgt_type = TYPE_TARGET_TYPE (fld_type);
if (TYPE_LENGTH (fld_type) >= 0 && TYPE_LENGTH (tgt_type) >= 0
if (TYPE_LENGTH (tgt_type) > 0
&& TYPE_LENGTH (fld_type) / TYPE_LENGTH (tgt_type) > 2)
return 1;
}