OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make some bpstat functions use bool

Browse Source 
Change return type to bool and adjust function comments.

gdb/ChangeLog:

	* breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
	bpstat_should_step): Return bool, adjust comments.
	* breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
	bpstat_should_step): Likewise.
This commit is contained in:
Simon Marchi 2019-07-10 12:10:51 -04:00 committed by Simon Marchi
parent 89abbcc26d
commit 4c462cb0ef
3 changed files with 27 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
* breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
bpstat_should_step): Return bool, adjust comments.
* breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
bpstat_should_step): Likewise.
2019-07-10 Alan Hayward <alan.hayward@arm.com>
* features/Makefile: Use feature target descriptions for Arm.

28
gdb/breakpoint.c
View File

@ -4231,7 +4231,7 @@ bpstat_find_breakpoint (bpstat bsp, struct breakpoint *breakpoint)
/* See breakpoint.h. */
int
bool
bpstat_explains_signal (bpstat bsp, enum gdb_signal sig)
{
for (; bsp != NULL; bsp = bsp->next)
@ -4241,17 +4241,17 @@ bpstat_explains_signal (bpstat bsp, enum gdb_signal sig)
/* A moribund location can never explain a signal other than
GDB_SIGNAL_TRAP. */
if (sig == GDB_SIGNAL_TRAP)
return 1;
return true;
}
else
{
if (bsp->breakpoint_at->ops->explains_signal (bsp->breakpoint_at,
sig))
return 1;
return true;
}
}
return 0;
return false;
}
/* Put in *NUM the breakpoint number of the first breakpoint we are
@ -5687,29 +5687,29 @@ bpstat_run_callbacks (bpstat bs_head)
}
}
/* Nonzero if we should step constantly (e.g. watchpoints on machines
without hardware support). This isn't related to a specific bpstat,
just to things like whether watchpoints are set. */
/* See breakpoint.h. */
int
bpstat_should_step (void)
bool
bpstat_should_step ()
{
struct breakpoint *b;
ALL_BREAKPOINTS (b)
if (breakpoint_enabled (b) && b->type == bp_watchpoint && b->loc != NULL)
return 1;
return 0;
return true;
return false;
}
int
/* See breakpoint.h. */
bool
bpstat_causes_stop (bpstat bs)
{
for (; bs != NULL; bs = bs->next)
if (bs->stop)
return 1;
return true;
return 0;
return false;
}

12
gdb/breakpoint.h
View File

@ -1061,18 +1061,18 @@ extern void bpstat_run_callbacks (bpstat bs_head);
/* Find the bpstat associated with a breakpoint. NULL otherwise. */
bpstat bpstat_find_breakpoint (bpstat, struct breakpoint *);
/* Nonzero if a signal that we got in target_wait() was due to
/* True if a signal that we got in target_wait() was due to
circumstances explained by the bpstat; the signal is therefore not
random. */
extern int bpstat_explains_signal (bpstat, enum gdb_signal);
extern bool bpstat_explains_signal (bpstat, enum gdb_signal);
/* Nonzero is this bpstat causes a stop. */
extern int bpstat_causes_stop (bpstat);
/* True if this bpstat causes a stop. */
extern bool bpstat_causes_stop (bpstat);
/* Nonzero if we should step constantly (e.g. watchpoints on machines
/* True if we should step constantly (e.g. watchpoints on machines
without hardware support). This isn't related to a specific bpstat,
just to things like whether watchpoints are set. */
extern int bpstat_should_step (void);
extern bool bpstat_should_step ();
/* Print a message indicating what happened. Returns nonzero to
say that only the source line should be printed after this (zero