OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add missing parentheses on 'print' (gdb.python/py-progspace.exp) 

Commit 33d569b709 ("gdb/python: Return
None from Progspace.block_for_pc on error") added a few tests on
gdb.python/py-progspace.exp which use 'print', but forgot to use
parentheses when passing the arguments to be printed.  This fails on
Python 3.

This commit adds these missing parentheses.  Pushed as obvious.

gdb/testsuite/ChangeLog:
2019-11-20  Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdb.python/py-progspace.exp: Add missing parentheses on some
	'print' commands.

Change-Id: Iac0a7578855d128bbee3b98e7ea5888dae55fc00
This commit is contained in:
Sergio Durigan Junior 2019-11-20 16:31:35 -05:00
parent 6cdd651fda
commit 4f22c3f42e
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2019-11-20 Sergio Durigan Junior <sergiodj@redhat.com>
* gdb.python/py-progspace.exp: Add missing parentheses on some
'print' commands.
2019-11-19 Tom Tromey <tom@tromey.com>
* gdb.tui/winheight.exp: New file.

6
gdb/testsuite/gdb.python/py-progspace.exp
View File

@ -61,14 +61,14 @@ if {![runto_main]} {
set pc_val [get_integer_valueof "\$pc" 0]
gdb_py_test_silent_cmd "python blk = gdb.current_progspace ().block_for_pc (${pc_val})" \
"get block for the current \$pc" 1
gdb_test "python print blk.start <= ${pc_val}" "True" \
gdb_test "python print (blk.start <= ${pc_val})" "True" \
"block start is before \$pc"
gdb_test "python print blk.end >= ${pc_val}" "True" \
gdb_test "python print (blk.end >= ${pc_val})" "True" \
"block end is after \$pc"
# Check what happens when we ask for a block of an invalid address.
if ![is_address_zero_readable] {
gdb_test "python print gdb.current_progspace ().block_for_pc (0)" "None"
gdb_test "python print (gdb.current_progspace ().block_for_pc (0))" "None"
}
# With a single inferior, progspace.objfiles () and gdb.objfiles () should