OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix ld --gc-section segfault with ARMv8-M entry function in absolute section

Browse Source 
bfd/
2016-09-14  Thomas Preud'homme  <thomas.preudhomme@arm.com>

	* elf32-arm.c (elf32_arm_gc_mark_extra_sections): Only mark section
	not already marked.

ld/
2016-09-14  Thomas Preud'homme  <thomas.preudhomme@arm.com>

	* testsuite/ld-arm/cmse-veneers.s: Add a test for ARMv8-M Security
	Extensions entry functions in absolute section.
	* testsuite/ld-arm/cmse-veneers.rd: Adapt expected output accordingly.
This commit is contained in:
Thomas Preud'homme 2016-09-14 16:02:17 +01:00
parent e6d042fe27
commit 4f90d84b2f
5 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bfd/ChangeLog
View File

@ -1,3 +1,8 @@
2016-09-14 Thomas Preud'homme <thomas.preudhomme@arm.com>
* elf32-arm.c (elf32_arm_gc_mark_extra_sections): Only mark section
not already marked.
2016-09-14 Nick Clifton <nickc@redhat.com>
PR binutils/20605

3
bfd/elf32-arm.c
View File

@ -14906,7 +14906,8 @@ elf32_arm_gc_mark_extra_sections (struct bfd_link_info *info,
if (ARM_GET_SYM_CMSE_SPCL (cmse_hash->root.target_internal))
{
cmse_sec = cmse_hash->root.root.u.def.section;
if (!_bfd_elf_gc_mark (info, cmse_sec, gc_mark_hook))
if (!cmse_sec->gc_mark &&
!_bfd_elf_gc_mark (info, cmse_sec, gc_mark_hook))
return FALSE;
}
}

6
ld/ChangeLog
View File

@ -1,3 +1,9 @@
2016-09-14 Thomas Preud'homme <thomas.preudhomme@arm.com>
* testsuite/ld-arm/cmse-veneers.s: Add a test for ARMv8-M Security
Extensions entry functions in absolute section.
* testsuite/ld-arm/cmse-veneers.rd: Adapt expected output accordingly.
2016-09-14 Claudiu Zissulescu <claziss@synopsys.com>
* testsuite/ld-arc/tls-dtpoff.dd: New file.

2
ld/testsuite/ld-arm/cmse-veneers.rd
View File

@ -1,4 +1,6 @@
#...
[0-9a-f]+ A abs_entry_fct
#...
[0-9a-f]+ T glob_entry_fct
#...
[0-9a-f]+ T glob_entry_veneer1

10
ld/testsuite/ld-arm/cmse-veneers.s
View File

@ -53,6 +53,16 @@ __acle_se_\name:
@ Valid setup for entry function without SG veneer
entry glob_entry_fct, function, global, entry_fct=nop
@ Valid setup for entry function with absolute address
.align 2
.global __acle_se_abs_entry_fct
.global abs_entry_fct
.type __acle_se_abs_entry_fct, %function
.type abs_entry_fct, %function
__acle_se_abs_entry_fct = 0x10000
abs_entry_fct = 0x10004
.size abs_entry_fct, 0
.size __acle_se_abs_entry_fct, 0
.else
@ Invalid setups for veneer generation (visibility)
entry loc_entry_veneer1, function, local