From 5063a42103f83b921b0b6899acdd5d4d920fdc36 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Mon, 7 Apr 2014 13:44:50 +0930 Subject: [PATCH] Report an error on objcopy/strip of sectionless binaries All strip operations require section headers to be present, as do most objcopy operations. BFD is seriously confused by objects without section info. The error message added here is similar to the error on attempting to strip/objcopy a zero length object. PR binutils/16811 * objcopy.c (copy_object): Error if no sections. --- binutils/ChangeLog | 5 +++++ binutils/objcopy.c | 7 +++++++ 2 files changed, 12 insertions(+) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 931d9d080d..56df68f03c 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,8 @@ +2014-04-07 Alan Modra + + PR binutils/16811 + * objcopy.c (copy_object): Error if no sections. + 2014-04-03 Markus Trippelsdorf PR binutils/14698 diff --git a/binutils/objcopy.c b/binutils/objcopy.c index 6215919bb7..873908c688 100644 --- a/binutils/objcopy.c +++ b/binutils/objcopy.c @@ -1598,6 +1598,13 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_info_type *input_arch) return FALSE; } + if (ibfd->sections == NULL) + { + non_fatal (_("error: the input file '%s' has no sections"), + bfd_get_archive_filename (ibfd)); + return FALSE; + } + if (verbose) printf (_("copy from `%s' [%s] to `%s' [%s]\n"), bfd_get_archive_filename (ibfd), bfd_get_target (ibfd),