OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

(Ada) "catch assert" spurious internal error 

We noticed while debugging a program compiled without assertions
enabled and using an older compiler that inserting a catchpoint
on failed assertions would cause an internal error:

    (gdb) catch assert
    ../../src/gdb/ada-lang.c:13321: internal-error: ada_exception_sal:
    Assertion`sym != NULL' failed.
    A problem internal to GDB has been detected,

This is due to a combination of factors:

  1. With older versions of the compiler, the function used as a hook
     was provided by a unit that's different from the unit which
     provides the hooks for the other exception catchpoints.

  2. The program either does not use any assertion, or is compiled
     without the assertions enabled.

With newer versions of the compiler, all such functions are provided
by the same unit, so should normally always be available.  However,
there can still be reasons why this is not the case. Consider, for
instance, the case of a runtime compiled with -ffunction-sections,
in which case the hook might be eliminated unless assertions are
used and enabled.

So this patch transforms the internal error into a simple error.

gdb/ChangeLog:

        * ada-lang.c (ada_exception_sal): Replace gdb_assert calls
        by calls to error.

No testcase added, as the existing testcase gdb.ada/catch_ex.exp
should trigger it when using an older version of GNAT as the Ada
compiler.
This commit is contained in:
Joel Brobecker 2018-09-08 16:46:08 -05:00
parent fb44b1a737
commit 57aff202b4
2 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2018-09-08 Joel Brobecker <brobecker@adacore.com>
* ada-lang.c (ada_exception_sal): Replace gdb_assert calls
by calls to error.
2018-09-08 Joel Brobecker <brobecker@adacore.com>
* ada-lang.c (ada_unhandled_exception_name_addr_from_raise):

11
gdb/ada-lang.c
View File

@ -13215,14 +13215,11 @@ ada_exception_sal (enum ada_exception_catchpoint_kind ex,
sym_name = ada_exception_sym_name (ex);
sym = standard_lookup (sym_name, NULL, VAR_DOMAIN);
/* We can assume that SYM is not NULL at this stage. If the symbol
did not exist, ada_exception_support_info_sniffer would have
raised an exception.
if (sym == NULL)
error (_("Catchpoint symbol not found: %s"), sym_name);
Also, ada_exception_support_info_sniffer should have already
verified that SYM is a function symbol. */
gdb_assert (sym != NULL);
gdb_assert (SYMBOL_CLASS (sym) == LOC_BLOCK);
if (SYMBOL_CLASS (sym) != LOC_BLOCK)
error (_("Unable to insert catchpoint. %s is not a function."), sym_name);
/* Set ADDR_STRING. */
*addr_string = xstrdup (sym_name);