OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

savestring: Rename parameter 'size' to 'len'.

Browse Source 
It's better to avoid needless confusion, and call string length,
length, instead of size, which is usually used to refer to sizeof of
the string (len+1):

	size_t len = strlen (str);
	size_t size = sizeof (str);

Tested on x86_64 Fedora 17.

2013-02-14  Pedro Alves  <palves@redhat.com>

	* utils.c (savestring): Rename parameter 'size' to 'len'.
This commit is contained in:
Pedro Alves 2013-02-14 17:09:00 +00:00
parent 420f4384af
commit 57c3b6ede5
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ChangeLog
View File

@ -1,3 +1,7 @@
2013-02-14 Pedro Alves <palves@redhat.com>
* utils.c (savestring): Rename parameter 'size' to 'len'.
2013-02-14 Pedro Alves <palves@redhat.com>
Yufeng Zhang <yufeng.zhang@arm.com>

10
gdb/utils.c
View File

@ -1186,17 +1186,17 @@ myread (int desc, char *addr, int len)
return orglen;
}
/* Make a copy of the string at PTR with SIZE characters
/* Make a copy of the string at PTR with LEN characters
(and add a null character at the end in the copy).
Uses malloc to get the space. Returns the address of the copy. */
char *
savestring (const char *ptr, size_t size)
savestring (const char *ptr, size_t len)
{
char *p = (char *) xmalloc (size + 1);
char *p = (char *) xmalloc (len + 1);
memcpy (p, ptr, size);
p[size] = 0;
memcpy (p, ptr, len);
p[len] = 0;
return p;
}