OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gdb: unconditionally define _initialize_string_view_selftests 

The build failure was noticed by Helmut Jarausch in
https://bugs.gentoo.org/680232:
    $ ./configure CXXFLAGS='-std=c++17 -Os'
    ...
      CXXLD  gdb
    ld: init.o: in function `initialize_all_files()':
    init.c:(.text+0x113): undefined reference to `_initialize_string_view_selftests()'

It happens because '_initialize_string_view_selftests()' is
conditionally defined based on C++ default.

The change defines '_initialize_string_view_selftests()'
unconditionally and leaves implementation a no-op on c++17
compilers.

gdb/ChangeLog:
2019-03-17  Sergei Trofimovich <siarheit@google.com>

	* unittests/string_view-selftests.c: Define
	_initialize_string_view_selftests unconditionally.
This commit is contained in:
Sergei Trofimovich 2019-03-17 22:27:31 +00:00 committed by Sergio Durigan Junior
parent a716e60cf9
commit 58785d9888
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2019-03-17 Sergei Trofimovich <siarheit@google.com>
* unittests/string_view-selftests.c: Define
_initialize_string_view_selftests unconditionally.
2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
PR gdb/24350

6
gdb/unittests/string_view-selftests.c
View File

@ -170,10 +170,12 @@ run_tests ()
} /* namespace string_view */
} /* namespace selftests */
#endif /* __cplusplus < 201703L */
void
_initialize_string_view_selftests ()
{
#if defined(GDB_STRING_VIEW)
selftests::register_test ("string_view", selftests::string_view::run_tests);
#endif
}
#endif /* __cplusplus < 201703L */