diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index be13f9b293..1227686426 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,10 @@ +2015-08-04 Yao Qi + + * linux-aarch64-low.c (aarch64_supports_z_point_type): Return + 0 for Z_PACKET_SW_BP if it may be used in multi-arch debugging. + * server.c (extended_protocol): Remove "static". + * server.h (extended_protocol): Declare it. + 2015-08-04 Yao Qi * linux-aarch64-low.c (aarch64_get_pc): Get PC register on diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c index 3512ce949d..90d2b43827 100644 --- a/gdb/gdbserver/linux-aarch64-low.c +++ b/gdb/gdbserver/linux-aarch64-low.c @@ -364,6 +364,22 @@ aarch64_supports_z_point_type (char z_type) switch (z_type) { case Z_PACKET_SW_BP: + { + if (!extended_protocol && is_64bit_tdesc ()) + { + /* Only enable Z0 packet in non-multi-arch debugging. If + extended protocol is used, don't enable Z0 packet because + GDBserver may attach to 32-bit process. */ + return 1; + } + else + { + /* Disable Z0 packet so that GDBserver doesn't have to handle + different breakpoint instructions (aarch64, arm, thumb etc) + in multi-arch debugging. */ + return 0; + } + } case Z_PACKET_HW_BP: case Z_PACKET_WRITE_WP: case Z_PACKET_READ_WP: diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c index 29187704c1..f15b7bedef 100644 --- a/gdb/gdbserver/server.c +++ b/gdb/gdbserver/server.c @@ -49,7 +49,7 @@ ptid_t general_thread; int server_waiting; -static int extended_protocol; +int extended_protocol; static int response_needed; static int exit_requested; diff --git a/gdb/gdbserver/server.h b/gdb/gdbserver/server.h index 09a5624557..9080151dd9 100644 --- a/gdb/gdbserver/server.h +++ b/gdb/gdbserver/server.h @@ -87,6 +87,7 @@ extern int multi_process; extern int report_fork_events; extern int report_vfork_events; extern int non_stop; +extern int extended_protocol; /* True if the "swbreak+" feature is active. In that case, GDB wants us to report whether a trap is explained by a software breakpoint