OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

find command, fix -Wpoint-sign

Browse Source 
From: Pedro Alves <palves@redhat.com>

The find command's patter/buffer that is passed to the target is a
binary blob, not a string.

$ make WERROR_CFLAGS="-Wpointer-sign -Werror" findcmd.o -k 2>&1 1>/dev/null
../../src/gdb/findcmd.c: In function ‘find_command’:
../../src/gdb/findcmd.c:278:6: error: pointer targets in passing argument 3 of ‘target_search_memory’ differ in signedness [-Werror=pointer-sign]
In file included from ../../src/gdb/findcmd.c:26:0:
../../src/gdb/target.h:1582:12: note: expected ‘const gdb_byte *’ but argument is of type ‘char *’

gdb/
2013-03-08  Pedro Alves  <palves@redhat.com>

	* findcmd.c (put_bits): Change type of parameter to 'gdb_byte *'.
	(parse_find_args, find_command): Change type of pattern buffer
	locals to 'gdb_byte *'.
This commit is contained in:
Pedro Alves 2013-03-08 15:22:44 +00:00
parent f6f899bfc5
commit 6221be90ef
2 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2013-03-08 Pedro Alves <palves@redhat.com>
* findcmd.c (put_bits): Change type of parameter to 'gdb_byte *'.
(parse_find_args, find_command): Change type of pattern buffer
locals to 'gdb_byte *'.
2012-03-08 Stan Shebs <stan@codesourcery.com> 2012-03-08 Stan Shebs <stan@codesourcery.com>
Hafiz Abid Qadeer <abidh@codesourcery.com> Hafiz Abid Qadeer <abidh@codesourcery.com>

10
gdb/findcmd.c
View File

@ -29,7 +29,7 @@
/* Copied from bfd_put_bits. */ /* Copied from bfd_put_bits. */
static void static void
put_bits (bfd_uint64_t data, char *buf, int bits, bfd_boolean big_p) put_bits (bfd_uint64_t data, gdb_byte *buf, int bits, bfd_boolean big_p)
{ {
int i; int i;
int bytes; int bytes;
@ -51,7 +51,7 @@ put_bits (bfd_uint64_t data, char *buf, int bits, bfd_boolean big_p)
static void static void
parse_find_args (char *args, ULONGEST *max_countp, parse_find_args (char *args, ULONGEST *max_countp,
char **pattern_bufp, ULONGEST *pattern_lenp, gdb_byte **pattern_bufp, ULONGEST *pattern_lenp,
CORE_ADDR *start_addrp, ULONGEST *search_space_lenp, CORE_ADDR *start_addrp, ULONGEST *search_space_lenp,
bfd_boolean big_p) bfd_boolean big_p)
{ {
@ -59,13 +59,13 @@ parse_find_args (char *args, ULONGEST *max_countp,
char size = '\0'; char size = '\0';
ULONGEST max_count = ~(ULONGEST) 0; ULONGEST max_count = ~(ULONGEST) 0;
/* Buffer to hold the search pattern. */ /* Buffer to hold the search pattern. */
char *pattern_buf; gdb_byte *pattern_buf;
/* Current size of search pattern buffer. /* Current size of search pattern buffer.
We realloc space as needed. */ We realloc space as needed. */
#define INITIAL_PATTERN_BUF_SIZE 100 #define INITIAL_PATTERN_BUF_SIZE 100
ULONGEST pattern_buf_size = INITIAL_PATTERN_BUF_SIZE; ULONGEST pattern_buf_size = INITIAL_PATTERN_BUF_SIZE;
/* Pointer to one past the last in-use part of pattern_buf. */ /* Pointer to one past the last in-use part of pattern_buf. */
char *pattern_buf_end; gdb_byte *pattern_buf_end;
ULONGEST pattern_len; ULONGEST pattern_len;
CORE_ADDR start_addr; CORE_ADDR start_addr;
ULONGEST search_space_len; ULONGEST search_space_len;
@ -249,7 +249,7 @@ find_command (char *args, int from_tty)
/* Command line parameters. /* Command line parameters.
These are initialized to avoid uninitialized warnings from -Wall. */ These are initialized to avoid uninitialized warnings from -Wall. */
ULONGEST max_count = 0; ULONGEST max_count = 0;
char *pattern_buf = 0; gdb_byte *pattern_buf = 0;
ULONGEST pattern_len = 0; ULONGEST pattern_len = 0;
CORE_ADDR start_addr = 0; CORE_ADDR start_addr = 0;
ULONGEST search_space_len = 0; ULONGEST search_space_len = 0;