OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove EXT_LANG_BT_COMPLETED

Browse Source 
While looking at the frame filter code, I noticed that
EXT_LANG_BT_COMPLETED is not really needed.  Semantically there is no
difference between the "completed" and "ok" results.  So, this patch
removes this constant.

gdb/ChangeLog
2018-03-26  Tom Tromey  <tom@tromey.com>

	* python/py-framefilter.c (py_print_frame): Return
	EXT_LANG_BT_OK.
	(gdbpy_apply_frame_filter): Update comment.
	* extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
	Remove.
	<EXT_LANG_BT_NO_FILTERS>: Change value.
This commit is contained in:
Tom Tromey 2017-04-23 11:07:26 -06:00
parent 978d6c756f
commit 63283d4a29
3 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gdb/ChangeLog
View File

@ -1,3 +1,12 @@
2018-03-26 Tom Tromey <tom@tromey.com>
* python/py-framefilter.c (py_print_frame): Return
EXT_LANG_BT_OK.
(gdbpy_apply_frame_filter): Update comment.
* extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
Remove.
<EXT_LANG_BT_NO_FILTERS>: Change value.
2018-03-26 Tom Tromey <tom@tromey.com>
PR backtrace/15582:

6
gdb/extension.h
View File

@ -76,13 +76,9 @@ enum ext_lang_bt_status
succeeded. */
EXT_LANG_BT_OK = 1,
/* Return when the frame filter process is complete, and all
operations have succeeded. */
EXT_LANG_BT_COMPLETED = 2,
/* Return when the frame filter process is complete, but there
were no filter registered and enabled to process. */
EXT_LANG_BT_NO_FILTERS = 3
EXT_LANG_BT_NO_FILTERS = 2
};
/* Flags to pass to apply_extlang_frame_filter. */

8
gdb/python/py-framefilter.c
View File

@ -916,7 +916,7 @@ py_print_args (PyObject *filter,
containing all the frames level that have already been printed.
If a frame level has been printed, do not print it again (in the
case of elided frames). Returns EXT_LANG_BT_ERROR on error, with any
GDB exceptions converted to a Python exception, or EXT_LANG_BT_COMPLETED
GDB exceptions converted to a Python exception, or EXT_LANG_BT_OK
on success. It can also throw an exception RETURN_QUIT. */
static enum ext_lang_bt_status
@ -969,7 +969,7 @@ py_print_frame (PyObject *filter, frame_filter_flags flags,
if (py_mi_print_variables (filter, out, &opts,
args_type, frame) == EXT_LANG_BT_ERROR)
return EXT_LANG_BT_ERROR;
return EXT_LANG_BT_COMPLETED;
return EXT_LANG_BT_OK;
}
gdb::optional<ui_out_emit_tuple> tuple;
@ -1270,7 +1270,7 @@ py_print_frame (PyObject *filter, frame_filter_flags flags,
}
}
return EXT_LANG_BT_COMPLETED;
return EXT_LANG_BT_OK;
}
/* Helper function to initiate frame filter invocation at starting
@ -1328,7 +1328,7 @@ bootstrap_python_frame_filters (struct frame_info *frame,
format, OUT is the output stream to print. FRAME_LOW is the
beginning of the slice of frames to print, and FRAME_HIGH is the
upper limit of the frames to count. Returns EXT_LANG_BT_ERROR on error,
or EXT_LANG_BT_COMPLETED on success. */
or EXT_LANG_BT_OK on success. */
enum ext_lang_bt_status
gdbpy_apply_frame_filter (const struct extension_language_defn *extlang,