OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix msp430 build with gcc-5

Browse Source 
gcc-5 correctly complains "loop exit may only be reached after
undefined behavior".  I was going to correct this by checking the
index before dereferencing the array rather than the other way around,
but then I noticed it is possible for extract_cmd to write the
terminating zero one past the end of "cmd".  Fixing that means no
index check is needed in md_assemble.

	* config/tc-msp430.c (md_assemble): Correct size passed to
	extract_cmd.  Remove index check.
This commit is contained in:
Alan Modra 2015-02-05 09:14:56 +10:30
parent b39b8b9d90
commit 64a81db054
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gas/ChangeLog
View File

@ -1,3 +1,8 @@
2015-02-05 Alan Modra <amodra@gmail.com>
* config/tc-msp430.c (md_assemble): Correct size passed to
extract_cmd. Remove index check.
2015-02-04 Matthew Wahab <matthew.wahab@arm.com>
* config/tc-aarch64.c (aarch64_cpus): Add support for Cortex-A72.

4
gas/config/tc-msp430.c
View File

@ -3174,9 +3174,9 @@ md_assemble (char * str)
unsigned int i = 0;
str = skip_space (str); /* Skip leading spaces. */
str = extract_cmd (str, cmd, sizeof (cmd));
str = extract_cmd (str, cmd, sizeof (cmd) - 1);
while (cmd[i] && i < sizeof (cmd))
while (cmd[i])
{
char a = TOLOWER (cmd[i]);
cmd[i] = a;