OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[Ada] pspace_data->sym_cache is always NULL

Browse Source 
The Ada symbol cache has been designed to have one instance of that
of that cache per program space, and for each instance to be created
on-demand. ada_get_symbol_cache is the function responsible for both
lookup and creation on demand.

Unfortunately, ada_get_symbol_cache forgot to store the reference
to newly created caches, thus causing it to:
  - Leak old caches;
  - Allocate a new cache each time the cache is being searched or
    a new entry is to be inserted.

This patch fixes the issue by avoiding the use of the local variable,
which indirectly allowed the bug to happen. We manipulate the reference
in the program-space data instead.

gdb/ChangeLog:

        PR gdb/17854:
        * ada-lang.c (ada_get_symbol_cache): Set pspace_data->sym_cache
        when allocating a new one.
This commit is contained in:
Joel Brobecker 2015-02-02 07:20:58 +04:00
parent ed2b91f0d8
commit 66c168ae56
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2015-02-02 Joel Brobecker <brobecker@adacore.com>
PR gdb/17854:
* ada-lang.c (ada_get_symbol_cache): Set pspace_data->sym_cache
when allocating a new one.
2015-02-01 Tom Tromey <tom@tromey.com>
* MAINTAINERS: Remove myself.

9
gdb/ada-lang.c
View File

@ -4404,15 +4404,14 @@ static struct ada_symbol_cache *
ada_get_symbol_cache (struct program_space *pspace)
{
struct ada_pspace_data *pspace_data = get_ada_pspace_data (pspace);
struct ada_symbol_cache *sym_cache = pspace_data->sym_cache;
if (sym_cache == NULL)
if (pspace_data->sym_cache == NULL)
{
sym_cache = XCNEW (struct ada_symbol_cache);
ada_init_symbol_cache (sym_cache);
pspace_data->sym_cache = XCNEW (struct ada_symbol_cache);
ada_init_symbol_cache (pspace_data->sym_cache);
}
return sym_cache;
return pspace_data->sym_cache;
}
/* Clear all entries from the symbol cache. */