Remove declarations of is_running/is_stopped/is_exited
The recent commit 0803633106
("Per-inferior thread list, thread
ranges/iterators, down with ALL_THREADS, etc.") removed the
definitions of is_running/is_stopped/is_exited but missed removing the
declarations.
gdb/ChangeLog:
2018-11-23 Pedro Alves <palves@redhat.com>
* gdbthread.h (enum thread_state): Move comments here.
(is_running, is_stopped, is_exited): Remove declarations.
This commit is contained in:
parent
8e4b639201
commit
6af05e645a
|
@ -1,3 +1,8 @@
|
||||||
|
2018-11-23 Pedro Alves <palves@redhat.com>
|
||||||
|
|
||||||
|
* gdbthread.h (enum thread_state): Move comments here.
|
||||||
|
(is_running, is_stopped, is_exited): Remove declarations.
|
||||||
|
|
||||||
2018-11-22 Pedro Alves <palves@redhat.com>
|
2018-11-22 Pedro Alves <palves@redhat.com>
|
||||||
|
|
||||||
* Makefile.in (COMMON_SFILES): Add thread-iter.c.
|
* Makefile.in (COMMON_SFILES): Add thread-iter.c.
|
||||||
|
|
|
@ -36,11 +36,32 @@ struct symtab;
|
||||||
struct inferior;
|
struct inferior;
|
||||||
|
|
||||||
/* Frontend view of the thread state. Possible extensions: stepping,
|
/* Frontend view of the thread state. Possible extensions: stepping,
|
||||||
finishing, until(ling),... */
|
finishing, until(ling),...
|
||||||
|
|
||||||
|
NOTE: Since the thread state is not a boolean, most times, you do
|
||||||
|
not want to check it with negation. If you really want to check if
|
||||||
|
the thread is stopped,
|
||||||
|
|
||||||
|
use (good):
|
||||||
|
|
||||||
|
if (tp->state == THREAD_STOPPED)
|
||||||
|
|
||||||
|
instead of (bad):
|
||||||
|
|
||||||
|
if (tp->state != THREAD_RUNNING)
|
||||||
|
|
||||||
|
The latter is also true for exited threads, most likely not what
|
||||||
|
you want. */
|
||||||
enum thread_state
|
enum thread_state
|
||||||
{
|
{
|
||||||
|
/* In the frontend's perpective, the thread is stopped. */
|
||||||
THREAD_STOPPED,
|
THREAD_STOPPED,
|
||||||
|
|
||||||
|
/* In the frontend's perpective, the thread is running. */
|
||||||
THREAD_RUNNING,
|
THREAD_RUNNING,
|
||||||
|
|
||||||
|
/* The thread is listed, but known to have exited. We keep it
|
||||||
|
listed (but not visible) until it's safe to delete it. */
|
||||||
THREAD_EXITED,
|
THREAD_EXITED,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
@ -566,31 +587,6 @@ extern void set_running (ptid_t ptid, int running);
|
||||||
observer is called with PTID as argument. */
|
observer is called with PTID as argument. */
|
||||||
extern void set_stop_requested (ptid_t ptid, int stop);
|
extern void set_stop_requested (ptid_t ptid, int stop);
|
||||||
|
|
||||||
/* NOTE: Since the thread state is not a boolean, most times, you do
|
|
||||||
not want to check it with negation. If you really want to check if
|
|
||||||
the thread is stopped,
|
|
||||||
|
|
||||||
use (good):
|
|
||||||
|
|
||||||
if (is_stopped (ptid))
|
|
||||||
|
|
||||||
instead of (bad):
|
|
||||||
|
|
||||||
if (!is_running (ptid))
|
|
||||||
|
|
||||||
The latter also returns true on exited threads, most likelly not
|
|
||||||
what you want. */
|
|
||||||
|
|
||||||
/* Reports if in the frontend's perpective, thread PTID is running. */
|
|
||||||
extern int is_running (ptid_t ptid);
|
|
||||||
|
|
||||||
/* Is this thread listed, but known to have exited? We keep it listed
|
|
||||||
(but not visible) until it's safe to delete. */
|
|
||||||
extern int is_exited (ptid_t ptid);
|
|
||||||
|
|
||||||
/* In the frontend's perpective, is this thread stopped? */
|
|
||||||
extern int is_stopped (ptid_t ptid);
|
|
||||||
|
|
||||||
/* Marks thread PTID as executing, or not. If PTID is minus_one_ptid,
|
/* Marks thread PTID as executing, or not. If PTID is minus_one_ptid,
|
||||||
marks all threads.
|
marks all threads.
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue