OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix snafu with booleans in readelf patch - lack of a program header is not a reason for a function to return false.

Browse Source 
(process_program_headers): Fix snafu - if the program headers are
	not available then this is not a cause to fail.
	(process_corefile_note_segments): Likewise.
This commit is contained in:
Nick Clifton 2017-02-24 18:15:12 +00:00
parent 34e4bae972
commit 6b4bf3bc35
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
binutils/ChangeLog
View File

@ -73,6 +73,9 @@
(process_object): Reverse the logic of the return value. (process_object): Reverse the logic of the return value.
(process_archive): Likewise. (process_archive): Likewise.
(process_file): Likewise. (process_file): Likewise.
(process_program_headers): Fix snafu - if the program headers are
not available then this is not a cause to fail.
(process_corefile_note_segments): Likewise.
2017-02-24 Maciej W. Rozycki <macro@imgtec.com> 2017-02-24 Maciej W. Rozycki <macro@imgtec.com>

7
binutils/readelf.c
View File

@ -4813,7 +4813,7 @@ process_program_headers (FILE * file)
} }
if (! get_program_headers (file)) if (! get_program_headers (file))
return FALSE; return TRUE;
if (do_segments) if (do_segments)
{ {
@ -16618,7 +16618,8 @@ process_notes_at (FILE * file,
inote.namedata = temp; inote.namedata = temp;
} }
res &= process_note (& inote, file, section); if (! process_note (& inote, file, section))
res = FALSE;
if (temp != NULL) if (temp != NULL)
{ {
@ -16640,7 +16641,7 @@ process_corefile_note_segments (FILE * file)
bfd_boolean res = TRUE; bfd_boolean res = TRUE;
if (! get_program_headers (file)) if (! get_program_headers (file))
return FALSE; return TRUE;
for (i = 0, segment = program_headers; for (i = 0, segment = program_headers;
i < elf_header.e_phnum; i < elf_header.e_phnum;