OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ubsan: v850: left shift cannot be represented in type 'int' 

Another 1 << 31 complaint.

	* v850-dis.c (disassemble): Avoid signed overflow.  Don't use
	long vars when unsigned int will do.
This commit is contained in:
Alan Modra 2019-12-26 15:56:25 +10:30
parent e5af216040
commit 6c2ca6c25d
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
opcodes/ChangeLog
View File

@ -1,3 +1,8 @@
2019-12-26 Alan Modra <amodra@gmail.com>
* v850-dis.c (disassemble): Avoid signed overflow. Don't use
long vars when unsigned int will do.
2019-12-24 Alan Modra <amodra@gmail.com>
* arm-dis.c (print_insn_arm): Don't shift by 32 on unsigned int var.

14
opcodes/v850-dis.c
View File

@ -499,7 +499,7 @@ disassemble (bfd_vma memaddr,
0, 0, 0, 0, 0, 31, 29, 28, 23, 22, 21, 20, 27, 26, 25, 24 };
int *regs;
int i;
unsigned long int mask = 0;
unsigned int mask = 0;
int pc = 0;
switch (operand->shift)
@ -514,12 +514,12 @@ disassemble (bfd_vma memaddr,
for (i = 0; i < 32; i++)
{
if (value & (1 << i))
if (value & (1u << i))
{
switch (regs[ i ])
{
default:
mask |= (1 << regs[ i ]);
mask |= (1u << regs[ i ]);
break;
case 0:
/* xgettext:c-format */
@ -543,10 +543,10 @@ disassemble (bfd_vma memaddr,
int shown_one = 0;
for (bit = 0; bit < 32; bit++)
if (mask & (1 << bit))
if (mask & (1u << bit))
{
unsigned long int first = bit;
unsigned long int last;
unsigned int first = bit;
unsigned int last;
if (shown_one)
info->fprintf_func (info->stream, ", ");
@ -556,7 +556,7 @@ disassemble (bfd_vma memaddr,
info->fprintf_func (info->stream, "%s", get_v850_reg_name (first));
for (bit++; bit < 32; bit++)
if ((mask & (1 << bit)) == 0)
if ((mask & (1u << bit)) == 0)
break;
last = bit;