OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gdbsupport: add format attribute to print_xml_feature::add_line

Browse Source 
Fixes this clang error:

      CXX      tdesc.o
    /home/smarchi/src/binutils-gdb/gdbsupport/tdesc.cc:444:25: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
      string_vappendf (tmp, fmt, ap);
                            ^~~

There is already a but about GCC not emitting this warning:

    https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82206

gdbsupport/ChangeLog:

	* tdesc.h (class print_xml_feature) <add_line>: Add
	ATTRIBUTE_PRINTF.

Change-Id: I7014075e83717f6d7e19d044a3675ff9981ebe17
This commit is contained in:
Simon Marchi 2020-06-27 14:38:43 -04:00 committed by Simon Marchi
parent 05779d57f9
commit 6db3031e5c
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdbsupport/ChangeLog
View File

@ -1,3 +1,8 @@
2020-06-27 Simon Marchi <simon.marchi@efficios.com>
* tdesc.h (class print_xml_feature) <add_line>: Add
ATTRIBUTE_PRINTF.
2020-06-23 Andrew Burgess <andrew.burgess@embecosm.com>
* tdesc.cc (print_xml_feature::visit_pre): Use add_line to add

2
gdbsupport/tdesc.h
View File

@ -438,7 +438,7 @@ private:
functions appends a newline, so don't include one in the strings being
passed. */
void add_line (const std::string &str);
void add_line (const char *fmt, ...);
void add_line (const char *fmt, ...) ATTRIBUTE_PRINTF (2, 3);
/* The buffer we are writing too. */
std::string *m_buffer;