OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix problem where undef can fail to trigger archive rescan. 

If a shared library contains an undefined symbol and LTO adds
a new reference to that same undefined symbol, the reference in the new
object added by the plugin would not trigger a rescan of the archive
containing the symbol.

2017-11-17  Stephen Crane  <sjc@immunant.com>

gold/
	PR gold/22448
	* symtab.cc (Symbol_table::add_from_object): Only rescan for
	undefined symbols in regular, not dynamic, objects.
This commit is contained in:
Stephen Crane 2017-12-01 12:10:02 -08:00 committed by Cary Coutant
parent e2e321740c
commit 71739b698d
2 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gold/ChangeLog
View File

@ -1,3 +1,9 @@
2017-11-17 Stephen Crane <sjc@immunant.com>
PR gold/22448
* symtab.cc (Symbol_table::add_from_object): Only rescan for
undefined symbols in regular, not dynamic, objects.
2017-11-30 Peter Smith <peter.smith@linaro.org>
PR gold/20765

15
gold/symtab.cc
View File

@ -990,7 +990,7 @@ Symbol_table::add_from_object(Object* object,
// ins.second: true if new entry was inserted, false if not.
Sized_symbol<size>* ret;
bool was_undefined;
bool was_undefined_in_reg;
bool was_common;
if (!ins.second)
{
@ -998,7 +998,7 @@ Symbol_table::add_from_object(Object* object,
ret = this->get_sized_symbol<size>(ins.first->second);
gold_assert(ret != NULL);
was_undefined = ret->is_undefined();
was_undefined_in_reg = ret->is_undefined() && ret->in_reg();
// Commons from plugins are just placeholders.
was_common = ret->is_common() && ret->object()->pluginobj() == NULL;
@ -1049,7 +1049,7 @@ Symbol_table::add_from_object(Object* object,
// it, then change it to NAME/VERSION.
ret = this->get_sized_symbol<size>(insdefault.first->second);
was_undefined = ret->is_undefined();
was_undefined_in_reg = ret->is_undefined() && ret->in_reg();
// Commons from plugins are just placeholders.
was_common = ret->is_common() && ret->object()->pluginobj() == NULL;
@ -1061,7 +1061,7 @@ Symbol_table::add_from_object(Object* object,
}
else
{
was_undefined = false;
was_undefined_in_reg = false;
was_common = false;
Sized_target<size, big_endian>* target =
@ -1105,9 +1105,10 @@ Symbol_table::add_from_object(Object* object,
ret->set_is_default();
}
// Record every time we see a new undefined symbol, to speed up
// archive groups.
if (!was_undefined && ret->is_undefined())
// Record every time we see a new undefined symbol, to speed up archive
// groups. We only care about symbols undefined in regular objects here
// because undefined symbols only in dynamic objects should't trigger rescans.
if (!was_undefined_in_reg && ret->is_undefined() && ret->in_reg())
{
++this->saw_undefined_;
if (parameters->options().has_plugins())