OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Replace xmalloc/xfree with vector in jit.c

Browse Source 
I'm currently studying that code and noticed this manual memory
management, which could easily be replaced with a vector, so here it is.

gdb/ChangeLog:

	* jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
	gdb::byte_vector.
This commit is contained in:
Simon Marchi 2019-12-12 14:54:47 -05:00 committed by Simon Marchi
parent d61df89700
commit 7190276c52
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
* jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
gdb::byte_vector.
2019-12-12 Tom Tromey <tromey@adacore.com>
* xml-support.c (xml_fetch_content_from_file): Don't call

9
gdb/jit.c
View File

@ -808,7 +808,6 @@ static int
jit_reader_try_read_symtab (struct jit_code_entry *code_entry,
CORE_ADDR entry_addr)
{
gdb_byte *gdb_mem;
int status;
jit_dbg_reader_data priv_data;
struct gdb_reader_funcs *funcs;
@ -831,12 +830,12 @@ jit_reader_try_read_symtab (struct jit_code_entry *code_entry,
if (!loaded_jit_reader)
return 0;
gdb_mem = (gdb_byte *) xmalloc (code_entry->symfile_size);
gdb::byte_vector gdb_mem (code_entry->symfile_size);
status = 1;
try
{
if (target_read_memory (code_entry->symfile_addr, gdb_mem,
if (target_read_memory (code_entry->symfile_addr, gdb_mem.data (),
code_entry->symfile_size))
status = 0;
}
@ -848,12 +847,12 @@ jit_reader_try_read_symtab (struct jit_code_entry *code_entry,
if (status)
{
funcs = loaded_jit_reader->functions;
if (funcs->read (funcs, &callbacks, gdb_mem, code_entry->symfile_size)
if (funcs->read (funcs, &callbacks, gdb_mem.data (),
code_entry->symfile_size)
!= GDB_SUCCESS)
status = 0;
}
xfree (gdb_mem);
if (jit_debug && status == 0)
fprintf_unfiltered (gdb_stdlog,
"Could not read symtab using the loaded JIT reader.\n");