OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gas: blackfin: fix LOOP_BEGIN/LOOP_END pseudo insns handling of local labels 

The current LOOP_BEGIN/LOOP_END pseudo insns hit "Internal errors" when
using local labels as the loop names due to attempts at removing them.

Signed-off-by: David Gibson <david.gibson@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
This commit is contained in:
Mike Frysinger 2010-10-11 08:35:53 +00:00
parent 71c5244065
commit 71ef6f79bc
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gas/ChangeLog
View File

@ -1,3 +1,7 @@
2010-09-11 David Gibson <david.gibson@analog.com>
* config/tc-bfin.c (bfin_gen_loop): Check symbol before removing.
2010-10-08 Pierre Muller <muller@ics.u-strasbg.fr>
Fix build with -DDEBUG=7

7
gas/config/tc-bfin.c
View File

@ -1874,6 +1874,7 @@ bfin_gen_loop (Expr_Node *exp, REG_T reg, int rop, REG_T preg)
char *lbeginsym, *lendsym;
Expr_Node_Value lbeginval, lendval;
Expr_Node *lbegin, *lend;
symbolS *sym;
loopsym = exp->value.s_value;
lbeginsym = (char *) xmalloc (strlen (loopsym) + strlen ("__BEGIN") + 5);
@ -1896,9 +1897,11 @@ bfin_gen_loop (Expr_Node *exp, REG_T reg, int rop, REG_T preg)
lbegin = Expr_Node_Create (Expr_Node_Reloc, lbeginval, NULL, NULL);
lend = Expr_Node_Create (Expr_Node_Reloc, lendval, NULL, NULL);
symbol_remove (symbol_find (loopsym), &symbol_rootP, &symbol_lastP);
sym = symbol_find(loopsym);
if (!S_IS_LOCAL (sym) || (S_IS_LOCAL (sym) && !symbol_used_p (sym)))
symbol_remove (sym, &symbol_rootP, &symbol_lastP);
return bfin_gen_loopsetup(lbegin, reg, rop, lend, preg);
return bfin_gen_loopsetup (lbegin, reg, rop, lend, preg);
}
void