OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update prompt_for_continue comments

Browse Source 
These comments are out of date -- we no longer call gdb_readline.  And
I think that mentioning the event loop is more useful here than
whatever GO32 issue had with gdb_readline, which may even no longer be
an issue.

gdb/ChangeLog:
2016-03-09  Pedro Alves  <palves@redhat.com>

	* utils.c (prompt_for_continue): Update comments.
This commit is contained in:
Pedro Alves 2016-03-09 18:24:59 +00:00
parent 608ff013aa
commit 720d2e96b4
2 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ChangeLog
View File

@ -1,3 +1,7 @@
2016-03-09 Pedro Alves <palves@redhat.com>
* utils.c (prompt_for_continue): Update comments.
2016-03-09 Pedro Alves <palves@redhat.com> 2016-03-09 Pedro Alves <palves@redhat.com>
* event-top.c (async_annotation_suffix): Delete. * event-top.c (async_annotation_suffix): Delete.

22
gdb/utils.c
View File

@ -1808,7 +1808,9 @@ set_screen_width_and_height (int width, int height)
} }
/* Wait, so the user can read what's on the screen. Prompt the user /* Wait, so the user can read what's on the screen. Prompt the user
to continue by pressing RETURN. */ to continue by pressing RETURN. 'q' is also provided because
telling users what to do in the prompt is more user-friendly than
expecting them to think of Ctrl-C/SIGINT. */
static void static void
prompt_for_continue (void) prompt_for_continue (void)
@ -1829,9 +1831,9 @@ prompt_for_continue (void)
if (annotation_level > 1) if (annotation_level > 1)
strcat (cont_prompt, "\n\032\032prompt-for-continue\n"); strcat (cont_prompt, "\n\032\032prompt-for-continue\n");
/* We must do this *before* we call gdb_readline, else it will eventually /* We must do this *before* we call gdb_readline_wrapper, else it
call us -- thinking that we're trying to print beyond the end of the will eventually call us -- thinking that we're trying to print
screen. */ beyond the end of the screen. */
reinitialize_more_filter (); reinitialize_more_filter ();
immediate_quit++; immediate_quit++;
@ -1840,16 +1842,8 @@ prompt_for_continue (void)
/* We'll need to handle input. */ /* We'll need to handle input. */
target_terminal_ours (); target_terminal_ours ();
/* On a real operating system, the user can quit with SIGINT. /* Call gdb_readline_wrapper, not readline, in order to keep an
But not on GO32. event loop running. */
'q' is provided on all systems so users don't have to change habits
from system to system, and because telling them what to do in
the prompt is more user-friendly than expecting them to think of
SIGINT. */
/* Call readline, not gdb_readline, because GO32 readline handles control-C
whereas control-C to gdb_readline will cause the user to get dumped
out to DOS. */
ignore = gdb_readline_wrapper (cont_prompt); ignore = gdb_readline_wrapper (cont_prompt);
/* Add time spend in this routine to prompt_for_continue_wait_time. */ /* Add time spend in this routine to prompt_for_continue_wait_time. */