From 73519cce7cbe31609a2aa9c27955555237a0c51f Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Fri, 4 Mar 2016 10:03:06 -0500 Subject: [PATCH] feature_to_c.sh: Print help when passing no arguments I found that odd that passing no arguments to feature_to_c.sh produces this: $ ./feature_to_c.sh ./feature_to_c.sh: 23: shift: can't shift that many but passing one argument shows the help: $ ./feature_to_c.sh hello Usage: ./feature_to_c.sh OUTPUTFILE INPUTFILE... This patch changes the script to show the help in both cases. gdb/ChangeLog: * features/feature_to_c.sh: Print the help when passing no argument. --- gdb/ChangeLog | 5 +++++ gdb/features/feature_to_c.sh | 8 ++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b94fcb1401..45c4c1d52e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2016-03-04 Simon Marchi + + * features/feature_to_c.sh: Print the help when passing no + argument. + 2016-03-02 Bernhard Heckel * MAINTAINERS (Write After Approval): Add Bernhard Heckel. diff --git a/gdb/features/feature_to_c.sh b/gdb/features/feature_to_c.sh index 901eb0dce5..439611a552 100755 --- a/gdb/features/feature_to_c.sh +++ b/gdb/features/feature_to_c.sh @@ -19,14 +19,14 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . -output=$1 -shift - -if test -z "$output" || test -z "$1"; then +if test -z "$1" || test -z "$2"; then echo "Usage: $0 OUTPUTFILE INPUTFILE..." exit 1 fi +output=$1 +shift + if test -e "$output"; then echo "Output file \"$output\" already exists; refusing to overwrite." exit 1