OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use "switch_to_thread" more thoroughly on gdbserver 

This is a technical debt that I left when I ported "switch_to_thread"
to gdbserver.  It's a simple patch that converts occurences of:

  current_thread = find_thread_ptid (ptid);

to:

  switch_to_thread (ptid);

This patch also converts a simple "if" to a "gdb_assert" on
gdbserver's version of "switch_to_thread":

  gdb_assert (ptid != minus_one_ptid);

This change makes the code more similar to what GDB already does.

Regtested on BuildBot.

gdb/gdbserver/ChangeLog:
2017-09-26  Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdbthread.h: Include "common-gdbthread.h".
	* inferiors.c (switch_to_thread): Use "gdb_assert" instead of
	"if" when validating the ptid.
	* remote-utils.c: Include "gdbthread.h".
	(prepare_resume_reply): Use "switch_to_thread".
	* target.c (done_accessing_memory): Likewise.
This commit is contained in:
Sergio Durigan Junior 2017-09-15 00:27:53 -04:00
parent 5007d765ae
commit 75352e283f
5 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gdb/gdbserver/ChangeLog
View File

@ -1,3 +1,12 @@
2017-09-26 Sergio Durigan Junior <sergiodj@redhat.com>
* gdbthread.h: Include "common-gdbthread.h".
* inferiors.c (switch_to_thread): Use "gdb_assert" instead of
"if" when validating the ptid.
* remote-utils.c: Include "gdbthread.h".
(prepare_resume_reply): Use "switch_to_thread".
* target.c (done_accessing_memory): Likewise.
2017-09-25 Andreas Arnez <arnez@linux.vnet.ibm.com>
* configure.srv (s390*-*-linux*): Add s390-gs-linux64.o and

1
gdb/gdbserver/gdbthread.h
View File

@ -19,6 +19,7 @@
#ifndef GDB_THREAD_H
#define GDB_THREAD_H
#include "common-gdbthread.h"
#include "inferiors.h"
struct btrace_target_info;

4
gdb/gdbserver/inferiors.c
View File

@ -442,6 +442,6 @@ make_cleanup_restore_current_thread (void)
void
switch_to_thread (ptid_t ptid)
{
if (!ptid_equal (ptid, minus_one_ptid))
current_thread = find_thread_ptid (ptid);
gdb_assert (ptid != minus_one_ptid);
current_thread = find_thread_ptid (ptid);
}

3
gdb/gdbserver/remote-utils.c
View File

@ -23,6 +23,7 @@
#include "tdesc.h"
#include "dll.h"
#include "rsp-low.h"
#include "gdbthread.h"
#include <ctype.h>
#if HAVE_SYS_IOCTL_H
#include <sys/ioctl.h>
@ -1188,7 +1189,7 @@ prepare_resume_reply (char *buf, ptid_t ptid,
saved_thread = current_thread;
current_thread = find_thread_ptid (ptid);
switch_to_thread (ptid);
regp = current_target_desc ()->expedite_regs;

2
gdb/gdbserver/target.c
View File

@ -138,7 +138,7 @@ done_accessing_memory (void)
/* Restore the previous selected thread. */
general_thread = prev_general_thread;
current_thread = find_thread_ptid (general_thread);
switch_to_thread (general_thread);
}
int