OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gdb: Fix toplevel types with -fdebug-types-section

Browse Source 
When debugging a program compiled with -fdebug-types-section,
only the first top-level type in each file is visible to gdb.

The problem was caused by moving the assignment to list_in_scope
from process_full_comp_unit and process_full_type_unit to
start_symtab.  This was fine for process_full_comp_unit, because
symtabs and comp units are one-to-one.  But there can be many type
units per symtab (one for each type), and we only call start_symtab
for the first one.  This adds the necessary assignments on the paths
where start_symtab is not called.

gdb/Changelog:

2020-04-28 Mark Williams <mark@myosotissp.com>

	PR gdb/24480
	* dwarf2read.c: Add missing assingments to list_in_scope when
	start_symtab was already called.

gdb/testsuite/Changelog:

2020-04-28 Mark Williams <mark@myosotissp.com>

	PR gdb/24480
	* dw4-toplevel-types.exp: Test for top level types.
	* dw4-toplevel-types.cc: Test for top level types.
This commit is contained in:
Mark Williams 2020-04-28 16:12:45 +02:00 committed by Tom de Vries
parent 1b95cdb76c
commit 770479f223
3 changed files with 59 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gdb/dwarf2/read.c
View File

@ -10921,6 +10921,7 @@ dwarf2_cu::setup_type_unit_groups (struct die_info *die)
COMPUNIT_DIRNAME (cust), COMPUNIT_DIRNAME (cust),
compunit_language (cust), compunit_language (cust),
0, cust)); 0, cust));
list_in_scope = get_builder ()->get_file_symbols ();
} }
return; return;
} }
@ -10972,6 +10973,7 @@ dwarf2_cu::setup_type_unit_groups (struct die_info *die)
COMPUNIT_DIRNAME (cust), COMPUNIT_DIRNAME (cust),
compunit_language (cust), compunit_language (cust),
0, cust)); 0, cust));
list_in_scope = get_builder ()->get_file_symbols ();
auto &file_names = line_header->file_names (); auto &file_names = line_header->file_names ();
for (i = 0; i < file_names.size (); ++i) for (i = 0; i < file_names.size (); ++i)

21
gdb/testsuite/gdb.dwarf2/dw4-toplevel-types.cc Normal file
View File

@ -0,0 +1,21 @@
/* This testcase is part of GDB, the GNU debugger.
Copyright 2020 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
struct X {} x;
struct Y {} y;
struct Z {} z;
int main() {}

36
gdb/testsuite/gdb.dwarf2/dw4-toplevel-types.exp Normal file
View File

@ -0,0 +1,36 @@
# Copyright 2020 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Test dwarf4 signatured types (DW_TAG_type_unit).
standard_testfile .cc
# This test is intended for targets which support DWARF-4.
# Since we pass an explicit -gdwarf-4 -fdebug-types-section to the compiler,
# we let that be the test of whether the target supports it.
if { [prepare_for_testing "failed to prepare" "${testfile}" \
$srcfile {debug c++ additional_flags=-gdwarf-4 \
additional_flags=-fdebug-types-section}] } {
return -1
}
if ![runto_main] {
return -1
}
gdb_test "ptype X" "type = struct X {.*"
gdb_test "ptype Y" "type = struct Y {.*"
gdb_test "ptype Z" "type = struct Z {.*"