OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove pst from dwarf_decode_lines_1

Browse Source 
Hi,
Parameter 'pst' of function dwarf_decode_lines_1 isn't used except
to compute decode_for_pst_p, which has been got in the caller
dwarf_decode_lines.  I wonder it would be good if we just pass
'decode_for_pst_p'.

gdb:

2014-08-15  Yao Qi  <yao@codesourcery.com>

	* dwarf2read.c (dwarf_decode_lines_1): Remove parameter 'pst'.
	Add parameter 'decode_for_pst_p'.  Callers update.
This commit is contained in:
Yao Qi 2014-08-04 14:26:25 +08:00
parent 60ac5798c8
commit 783cecc8b3
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2014-08-15 Yao Qi <yao@codesourcery.com>
* dwarf2read.c (dwarf_decode_lines_1): Remove parameter 'pst'.
Add parameter 'decode_for_pst_p'. Callers update.
2014-08-13 Yao Qi <yao@codesourcery.com>
PR build/17104

5
gdb/dwarf2read.c
View File

@ -17177,7 +17177,7 @@ noop_record_line (struct subfile *subfile, int line, CORE_ADDR pc)
static void
dwarf_decode_lines_1 (struct line_header *lh, const char *comp_dir,
struct dwarf2_cu *cu, struct partial_symtab *pst)
struct dwarf2_cu *cu, const int decode_for_pst_p)
{
const gdb_byte *line_ptr, *extended_end;
const gdb_byte *line_end;
@ -17187,7 +17187,6 @@ dwarf_decode_lines_1 (struct line_header *lh, const char *comp_dir,
struct objfile *objfile = cu->objfile;
bfd *abfd = objfile->obfd;
struct gdbarch *gdbarch = get_objfile_arch (objfile);
const int decode_for_pst_p = (pst != NULL);
struct subfile *last_subfile = NULL;
void (*p_record_line) (struct subfile *subfile, int line, CORE_ADDR pc)
= record_line;
@ -17501,7 +17500,7 @@ dwarf_decode_lines (struct line_header *lh, const char *comp_dir,
struct subfile *first_subfile = current_subfile;
if (want_line_info)
dwarf_decode_lines_1 (lh, comp_dir, cu, pst);
dwarf_decode_lines_1 (lh, comp_dir, cu, decode_for_pst_p);
if (decode_for_pst_p)
{