OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

testsuite: diagnose a running GDB in gdb_skip_xml_tests 

If GDB is running when gdb_skip_xml_tests is called with
--target_board=native-extended-gdbserer.exp, it fails with:

    (gdb) FAIL: ....exp: set tdesc filename .../trivial.xml (got interactive prompt)
    monitor exit

Diagnose this in gdb_skip_xml_tests to generate a more meaningful error message:

    ERROR: tcl error sourcing ....exp.
    ERROR: GDB must not be running in gdb_skip_xml_tests.
        while executing
    [...]

testsuite/
	* lib/gdb.exp (gdb_skip_xml_tests): Error if GDB is running.
This commit is contained in:
Markus Metzger 2017-01-31 17:13:46 +01:00
parent 68777c2989
commit 787f00256b
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,7 @@
2017-02-01 Markus Metzger <markus.t.metzger@intel.com>
* lib/gdb.exp (gdb_skip_xml_tests): Error if GDB is running.
2017-02-01 Markus Metzger <markus.t.metzger@intel.com>
* gdb.btrace/enable.exp: Call gdb_exit before

5
gdb/testsuite/lib/gdb.exp
View File

@ -5030,9 +5030,14 @@ proc gdb_skip_bogus_test { msg } {
# NOTE: This must be called while gdb is *not* running.
gdb_caching_proc gdb_skip_xml_test {
global gdb_spawn_id
global gdb_prompt
global srcdir
if { [info exists gdb_spawn_id] } {
error "GDB must not be running in gdb_skip_xml_tests."
}
set xml_file [gdb_remote_download host "${srcdir}/gdb.xml/trivial.xml"]
gdb_start