OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove usage of find_inferior in linux_detach 

Replace with for_each_thread with pid filtering.

gdb/gdbserver/ChangeLog:

	* linux-low.c (linux_detach_lwp_callback): Return void, remove
	args parameter, don't check for pid.
	(linux_detach): Use for_each_thread.
This commit is contained in:
Simon Marchi 2017-12-02 20:36:36 -05:00
parent e4eb0dec0b
commit 798a38e8de
2 changed files with 13 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/gdbserver/ChangeLog
View File

@ -1,3 +1,9 @@
2017-12-02 Simon Marchi <simon.marchi@polymtl.ca>
* linux-low.c (linux_detach_lwp_callback): Return void, remove
args parameter, don't check for pid.
(linux_detach): Use for_each_thread.
2017-12-02 Simon Marchi <simon.marchi@polymtl.ca>
* linux-low.c (struct counter): Remove.

22
gdb/gdbserver/linux-low.c
View File

@ -1581,28 +1581,20 @@ linux_detach_one_lwp (struct lwp_info *lwp)
delete_lwp (lwp);
}
/* Callback for find_inferior. Detaches from non-leader threads of a
/* Callback for for_each_thread. Detaches from non-leader threads of a
given process. */
static int
linux_detach_lwp_callback (thread_info *thread, void *args)
static void
linux_detach_lwp_callback (thread_info *thread)
{
struct lwp_info *lwp = get_thread_lwp (thread);
int pid = *(int *) args;
int lwpid = lwpid_of (thread);
/* Skip other processes. */
if (thread->id.pid () != pid)
return 0;
/* We don't actually detach from the thread group leader just yet.
If the thread group exits, we must reap the zombie clone lwps
before we're able to reap the leader. */
if (thread->id.pid () == lwpid)
return 0;
if (thread->id.pid () == thread->id.lwp ())
return;
lwp_info *lwp = get_thread_lwp (thread);
linux_detach_one_lwp (lwp);
return 0;
}
static int
@ -1636,7 +1628,7 @@ linux_detach (int pid)
/* Detach from the clone lwps first. If the thread group exits just
while we're detaching, we must reap the clone lwps before we're
able to reap the leader. */
find_inferior (&all_threads, linux_detach_lwp_callback, &pid);
for_each_thread (pid, linux_detach_lwp_callback);
main_lwp = find_lwp_pid (pid_to_ptid (pid));
linux_detach_one_lwp (main_lwp);