OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix build failure in symfile.c::unmap_overlay_command (GCC5 bug)

Browse Source 
Compilation of (GDB) 7.9.50.20150127-cvs with (GCC) 5.0.0 20150127
fails with

In file included from symfile.c:32:0:
symfile.c: In function 'unmap_overlay_command':
objfiles.h:628:3: error: 'sec' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
   for (osect = objfile->sections; osect < objfile->sections_end; osect++) \
   ^
symfile.c:3442:23: note: 'sec' was declared here
   struct obj_section *sec;
                       ^
cc1: all warnings being treated as errors
make[2]: *** [symfile.o] Error 1
make[2]: Leaving directory `gdb/gdb'

While the bug was reported to GCC as
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64823>,
the attached patch simply initializes sec with NULL.

gdb/ChangeLog:

        * symfile.c (unmap_overlay_command): Initialize sec to NULL.

Tested on x86_64-linux.
This commit is contained in:
Alexander Klimov 2015-01-27 19:56:45 +02:00 committed by Joel Brobecker
parent b86ac8e3a5
commit 7a270e0c9b
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ChangeLog
View File

@ -1,3 +1,7 @@
2015-01-29 Joel Brobecker <brobecker@adacore.com> (tiny patch)
* symfile.c (unmap_overlay_command): Initialize sec to NULL.
2015-01-27 Doug Evans <dje@google.com>
* NEWS: Mention gdb.Objfile.username.

2
gdb/symfile.c
View File

@ -3439,7 +3439,7 @@ static void
unmap_overlay_command (char *args, int from_tty)
{
struct objfile *objfile;
struct obj_section *sec;
struct obj_section *sec = NULL;
if (!overlay_debugging)
error (_("Overlay debugging not enabled. "