OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Store the mangled name as a string_view 

This should be a bit faster (because we can compare the size first),
but it is also a dependency for the next patch.

(3.47% of gdb startup time is spent in eq_demangled_name_entry when
attaching to Chrome's content_shell binary)

gdb/ChangeLog:

2019-10-22  Christian Biesinger  <cbiesinger@google.com>

	* symtab.c (struct demangled_name_entry): Change type of mangled
	to gdb::string_view. Also adds a constructor that takes the
	mangled name.
	(hash_demangled_name_entry): Update.
	(eq_demangled_name_entry): Update.
	(free_demangled_name_entry): New function to call the destructor
	now that this is not a POD anymore.
	(create_demangled_names_hash): Pass free_demangled_name_entry to
	htab_create_alloc.
	(symbol_set_names): Update.

Change-Id: I24711ae2bcaa9e79ca89a6f8fda385d400419175
This commit is contained in:
Christian Biesinger 2019-09-27 12:40:04 -05:00
parent 6207ed2877
commit 7bb4305982
2 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
gdb/ChangeLog
View File

@ -1,3 +1,16 @@
2019-10-22 Christian Biesinger <cbiesinger@google.com>
* symtab.c (struct demangled_name_entry): Change type of mangled
to gdb::string_view. Also adds a constructor that takes the
mangled name.
(hash_demangled_name_entry): Update.
(eq_demangled_name_entry): Update.
(free_demangled_name_entry): New function to call the destructor
now that this is not a POD anymore.
(create_demangled_names_hash): Pass free_demangled_name_entry to
htab_create_alloc.
(symbol_set_names): Update.
2019-10-21 Ali Tamur <tamu@google.com>
* dwarf2read.c (dir_index): Change type.

15
gdb/symtab.c
View File

@ -68,6 +68,7 @@
#include "filename-seen-cache.h"
#include "arch-utils.h"
#include <algorithm>
#include "gdbsupport/gdb_string_view.h"
#include "gdbsupport/pathstuff.h"
/* Forward declarations for local functions. */
@ -713,7 +714,7 @@ symbol_set_language (struct general_symbol_info *gsymbol,
/* Objects of this type are stored in the demangled name hash table. */
struct demangled_name_entry
{
const char *mangled;
gdb::string_view mangled;
ENUM_BITFIELD(language) language : LANGUAGE_BITS;
char demangled[1];
};
@ -726,7 +727,7 @@ hash_demangled_name_entry (const void *data)
const struct demangled_name_entry *e
= (const struct demangled_name_entry *) data;
return htab_hash_string (e->mangled);
return iterative_hash (e->mangled.data (), e->mangled.length (), 0);
}
/* Equality function for the demangled name hash. */
@ -739,7 +740,7 @@ eq_demangled_name_entry (const void *a, const void *b)
const struct demangled_name_entry *db
= (const struct demangled_name_entry *) b;
return strcmp (da->mangled, db->mangled) == 0;
return da->mangled == db->mangled;
}
/* Create the hash table used for demangled names. Each hash entry is
@ -855,7 +856,7 @@ symbol_set_names (struct general_symbol_info *gsymbol,
else
linkage_name_copy = linkage_name;
entry.mangled = linkage_name_copy;
entry.mangled = gdb::string_view (linkage_name_copy, len);
slot = ((struct demangled_name_entry **)
htab_find_slot (per_bfd->demangled_names_hash.get (),
&entry, INSERT));
@ -888,7 +889,7 @@ symbol_set_names (struct general_symbol_info *gsymbol,
obstack_alloc (&per_bfd->storage_obstack,
offsetof (struct demangled_name_entry, demangled)
+ demangled_len + 1));
(*slot)->mangled = linkage_name;
(*slot)->mangled = gdb::string_view (linkage_name, len);
}
else
{
@ -904,7 +905,7 @@ symbol_set_names (struct general_symbol_info *gsymbol,
+ len + demangled_len + 2));
mangled_ptr = &((*slot)->demangled[demangled_len + 1]);
strcpy (mangled_ptr, linkage_name_copy);
(*slot)->mangled = mangled_ptr;
(*slot)->mangled = gdb::string_view (mangled_ptr, len);
}
(*slot)->language = gsymbol->language;
@ -917,7 +918,7 @@ symbol_set_names (struct general_symbol_info *gsymbol,
|| gsymbol->language == language_auto)
gsymbol->language = (*slot)->language;
gsymbol->name = (*slot)->mangled;
gsymbol->name = (*slot)->mangled.data ();
if ((*slot)->demangled[0] != '\0')
symbol_set_demangled_name (gsymbol, (*slot)->demangled,
&per_bfd->storage_obstack);