diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 8e358dd575..8ac776505f 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2017-11-16 Nick Clifton + + PR 22421 + * elf.c (elfcore_grok_netbsd_procinfo): Check that the note is big enough. + (elfcore_grok_openbsd_procinfo): Likewise. + (elfcore_grok_nto_status): Likewise. + 2017-11-16 Nick Clifton * merge.c (sec_merge_emit): Always create padding buffer. Add diff --git a/bfd/elf.c b/bfd/elf.c index 694e43540f..93ed443b05 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -9871,6 +9871,7 @@ elfcore_grok_freebsd_psinfo (bfd *abfd, Elf_Internal_Note *note) /* Check for version 1 in pr_version. */ if (bfd_h_get_32 (abfd, (bfd_byte *) note->descdata) != 1) return FALSE; + offset = 4; /* Skip over pr_psinfosz. */ @@ -10051,6 +10052,9 @@ elfcore_netbsd_get_lwpid (Elf_Internal_Note *note, int *lwpidp) static bfd_boolean elfcore_grok_netbsd_procinfo (bfd *abfd, Elf_Internal_Note *note) { + if (note->descsz <= 0x7c + 31) + return FALSE; + /* Signal number at offset 0x08. */ elf_tdata (abfd)->core->signal = bfd_h_get_32 (abfd, (bfd_byte *) note->descdata + 0x08); @@ -10135,6 +10139,9 @@ elfcore_grok_netbsd_note (bfd *abfd, Elf_Internal_Note *note) static bfd_boolean elfcore_grok_openbsd_procinfo (bfd *abfd, Elf_Internal_Note *note) { + if (note->descsz <= 0x48 + 31) + return FALSE; + /* Signal number at offset 0x08. */ elf_tdata (abfd)->core->signal = bfd_h_get_32 (abfd, (bfd_byte *) note->descdata + 0x08); @@ -10206,6 +10213,9 @@ elfcore_grok_nto_status (bfd *abfd, Elf_Internal_Note *note, long *tid) short sig; unsigned flags; + if (note->descsz < 16) + return FALSE; + /* nto_procfs_status 'pid' field is at offset 0. */ elf_tdata (abfd)->core->pid = bfd_get_32 (abfd, (bfd_byte *) ddata);