OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Improve File I/O overflow detection in gdbserver (PR server/23198)

Browse Source 
Currently, the function used by gdbserver to parse integers from
received File I/O commands will detect overflow and fail for any value
over 0xfffffff.  Among other things, this has the effect of limiting
the file offsets for reading or writing to about 268MB which can be
insufficient for particularly large libraries.

This change allows the parsing of integers up to the true maximum
positive value of 0x7fffffff, increasing the file size limit to about
2GB.

gdb/gdbserver/ChangeLog:
2018-05-23  Erik Kurzinger  <ekurzinger@nvidia.com>

	PR server/23198
	* hostio.c (require_int): Do not report overflow for integers
	between 0xfffffff and 0x7fffffff.
This commit is contained in:
Erik Kurzinger 2018-05-23 12:04:39 +01:00 committed by Pedro Alves
parent f2a3bd7da2
commit 81e25b7c91
2 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/gdbserver/ChangeLog
View File

@ -1,3 +1,9 @@
2018-05-23 Erik Kurzinger <ekurzinger@nvidia.com>
PR server/23198
* hostio.c (require_int): Do not report overflow for integers
between 0xfffffff and 0x7fffffff.
2018-05-22 Maciej W. Rozycki <macro@mips.com>
* linux-mips-low.c [HAVE_PTRACE_GETREGS] (mips_collect_register)

15
gdb/gdbserver/hostio.c
View File

@ -96,22 +96,27 @@ static int
require_int (char **pp, int *value)
{
char *p;
int count;
int count, firstdigit;
p = *pp;
*value = 0;
count = 0;
firstdigit = -1;
while (*p && *p != ',')
{
int nib;
/* Don't allow overflow. */
if (count >= 7)
return -1;
if (safe_fromhex (p[0], &nib))
return -1;
if (firstdigit == -1)
firstdigit = nib;
/* Don't allow overflow. */
if (count >= 8 || (count == 7 && firstdigit >= 0x8))
return -1;
*value = *value * 16 + nib;
p++;
count++;