Set architecture to arm in arm-*.xml files
This patch is to add the following line to various arm target description xml files, <architecture>arm</architecture> in order to fix problems I've seen on aarch64 multi-arch debugging, detach^M Detaching from program: build-gdb/gdb/testsuite/gdb.base/attach, process 17145^M (gdb) PASS: gdb.base/attach.exp: attach1 detach file^M No executable file now.^M Architecture of file not recognized.^M (gdb) FAIL: gdb.base/attach.exp: attach1, purging symbols after detach Without this patch, struct target_desc *tdesc_* are not initialised properly, that is, fields arch and osabi in 'struct target_desc' are not set properly. This doesn't cause any problems on single arch debugging, because arch-utils.c:gdbarch_info_fill will guess correctly. However, in multi-arch debugging, gdbarch_info_fill gets the aarch64 arch, but the target description is for arm (because the current inferior is 32-bit arm). It is a surprise to me we didn't set architecture to "arm" before in *.xml files, and I didn't find out why didn't do so. AFAICS, gdb/features/arm-with-iwmmxt.xml was added firstly (in patch https://sourceware.org/ml/gdb-patches/2007-01/msg00593.html) which had <architecture>iwmmxt</architecture>, however, afterwards, architecture isn't set anymore in features/arm-*.xml files (in patches https://sourceware.org/ml/gdb-patches/2009-07/msg00689.html and https://sourceware.org/ml/gdb-patches/2010-08/msg00225.html). gdb: 2015-07-07 Yao Qi <yao.qi@linaro.org> * features/arm-with-m-fpa-layout.xml: Set architecture to arm. * features/arm-with-m-fpa-layout.c: Regenerated. * features/arm-with-m-vfp-d16.xml: Likewise. * features/arm-with-m-vfp-d16.c: Regenerated. * features/arm-with-m.xml: Likewise. * features/arm-with-m.c: Regenerated. * features/arm-with-neon.xml: Likewise. * features/arm-with-neon.c: Regenerated. * features/arm-with-vfpv2.xml: Likewise. * features/arm-with-vfpv2.c: Regenerated. * features/arm-with-vfpv3.xml: Likewise. * features/arm-with-vfpv3.c: Regenerated.
This commit is contained in:
parent
607685ecee
commit
82c40d4b1d
|
@ -1,3 +1,18 @@
|
|||
2015-07-07 Yao Qi <yao.qi@linaro.org>
|
||||
|
||||
* features/arm-with-m-fpa-layout.xml: Set architecture to arm.
|
||||
* features/arm-with-m-fpa-layout.c: Regenerated.
|
||||
* features/arm-with-m-vfp-d16.xml: Likewise.
|
||||
* features/arm-with-m-vfp-d16.c: Regenerated.
|
||||
* features/arm-with-m.xml: Likewise.
|
||||
* features/arm-with-m.c: Regenerated.
|
||||
* features/arm-with-neon.xml: Likewise.
|
||||
* features/arm-with-neon.c: Regenerated.
|
||||
* features/arm-with-vfpv2.xml: Likewise.
|
||||
* features/arm-with-vfpv2.c: Regenerated.
|
||||
* features/arm-with-vfpv3.xml: Likewise.
|
||||
* features/arm-with-vfpv3.c: Regenerated.
|
||||
|
||||
2015-07-07 Yao Qi <yao.qi@linaro.org>
|
||||
|
||||
* aarch32-linux-nat.h (VFP_REGS_SIZE): New macro, moved from
|
||||
|
|
|
@ -12,6 +12,8 @@ initialize_tdesc_arm_with_m_fpa_layout (void)
|
|||
struct target_desc *result = allocate_target_description ();
|
||||
struct tdesc_feature *feature;
|
||||
|
||||
set_tdesc_architecture (result, bfd_scan_arch ("arm"));
|
||||
|
||||
feature = tdesc_create_feature (result, "org.gnu.gdb.arm.m-profile");
|
||||
tdesc_create_reg (feature, "r0", 0, 1, NULL, 32, "int");
|
||||
tdesc_create_reg (feature, "r1", 1, 1, NULL, 32, "int");
|
||||
|
|
|
@ -10,6 +10,7 @@
|
|||
|
||||
<!DOCTYPE target SYSTEM "gdb-target.dtd">
|
||||
<target>
|
||||
<architecture>arm</architecture>
|
||||
<feature name="org.gnu.gdb.arm.m-profile">
|
||||
<reg name="r0" bitsize="32"/>
|
||||
<reg name="r1" bitsize="32"/>
|
||||
|
|
|
@ -12,6 +12,8 @@ initialize_tdesc_arm_with_m_vfp_d16 (void)
|
|||
struct target_desc *result = allocate_target_description ();
|
||||
struct tdesc_feature *feature;
|
||||
|
||||
set_tdesc_architecture (result, bfd_scan_arch ("arm"));
|
||||
|
||||
feature = tdesc_create_feature (result, "org.gnu.gdb.arm.m-profile");
|
||||
tdesc_create_reg (feature, "r0", 0, 1, NULL, 32, "int");
|
||||
tdesc_create_reg (feature, "r1", 1, 1, NULL, 32, "int");
|
||||
|
|
|
@ -7,6 +7,7 @@
|
|||
|
||||
<!DOCTYPE target SYSTEM "gdb-target.dtd">
|
||||
<target>
|
||||
<architecture>arm</architecture>
|
||||
<xi:include href="arm-m-profile.xml"/>
|
||||
<!-- Layout of vfpv4-sp-d16 is identical to vfpv2 -->
|
||||
<xi:include href="arm-vfpv2.xml"/>
|
||||
|
|
|
@ -12,6 +12,8 @@ initialize_tdesc_arm_with_m (void)
|
|||
struct target_desc *result = allocate_target_description ();
|
||||
struct tdesc_feature *feature;
|
||||
|
||||
set_tdesc_architecture (result, bfd_scan_arch ("arm"));
|
||||
|
||||
feature = tdesc_create_feature (result, "org.gnu.gdb.arm.m-profile");
|
||||
tdesc_create_reg (feature, "r0", 0, 1, NULL, 32, "int");
|
||||
tdesc_create_reg (feature, "r1", 1, 1, NULL, 32, "int");
|
||||
|
|
|
@ -7,5 +7,6 @@
|
|||
|
||||
<!DOCTYPE target SYSTEM "gdb-target.dtd">
|
||||
<target>
|
||||
<architecture>arm</architecture>
|
||||
<xi:include href="arm-m-profile.xml"/>
|
||||
</target>
|
||||
|
|
|
@ -12,6 +12,8 @@ initialize_tdesc_arm_with_neon (void)
|
|||
struct target_desc *result = allocate_target_description ();
|
||||
struct tdesc_feature *feature;
|
||||
|
||||
set_tdesc_architecture (result, bfd_scan_arch ("arm"));
|
||||
|
||||
feature = tdesc_create_feature (result, "org.gnu.gdb.arm.core");
|
||||
tdesc_create_reg (feature, "r0", 0, 1, NULL, 32, "uint32");
|
||||
tdesc_create_reg (feature, "r1", 1, 1, NULL, 32, "uint32");
|
||||
|
|
|
@ -7,6 +7,7 @@
|
|||
|
||||
<!DOCTYPE target SYSTEM "gdb-target.dtd">
|
||||
<target>
|
||||
<architecture>arm</architecture>
|
||||
<xi:include href="arm-core.xml"/>
|
||||
<xi:include href="arm-vfpv3.xml"/>
|
||||
<feature name="org.gnu.gdb.arm.neon"/>
|
||||
|
|
|
@ -12,6 +12,8 @@ initialize_tdesc_arm_with_vfpv2 (void)
|
|||
struct target_desc *result = allocate_target_description ();
|
||||
struct tdesc_feature *feature;
|
||||
|
||||
set_tdesc_architecture (result, bfd_scan_arch ("arm"));
|
||||
|
||||
feature = tdesc_create_feature (result, "org.gnu.gdb.arm.core");
|
||||
tdesc_create_reg (feature, "r0", 0, 1, NULL, 32, "uint32");
|
||||
tdesc_create_reg (feature, "r1", 1, 1, NULL, 32, "uint32");
|
||||
|
|
|
@ -7,6 +7,7 @@
|
|||
|
||||
<!DOCTYPE target SYSTEM "gdb-target.dtd">
|
||||
<target>
|
||||
<architecture>arm</architecture>
|
||||
<xi:include href="arm-core.xml"/>
|
||||
<xi:include href="arm-vfpv2.xml"/>
|
||||
</target>
|
||||
|
|
|
@ -12,6 +12,8 @@ initialize_tdesc_arm_with_vfpv3 (void)
|
|||
struct target_desc *result = allocate_target_description ();
|
||||
struct tdesc_feature *feature;
|
||||
|
||||
set_tdesc_architecture (result, bfd_scan_arch ("arm"));
|
||||
|
||||
feature = tdesc_create_feature (result, "org.gnu.gdb.arm.core");
|
||||
tdesc_create_reg (feature, "r0", 0, 1, NULL, 32, "uint32");
|
||||
tdesc_create_reg (feature, "r1", 1, 1, NULL, 32, "uint32");
|
||||
|
|
|
@ -7,6 +7,7 @@
|
|||
|
||||
<!DOCTYPE target SYSTEM "gdb-target.dtd">
|
||||
<target>
|
||||
<architecture>arm</architecture>
|
||||
<xi:include href="arm-core.xml"/>
|
||||
<xi:include href="arm-vfpv3.xml"/>
|
||||
</target>
|
||||
|
|
Loading…
Reference in New Issue