gnulib's sys/stat.h always defines S_IRGRP, S_IXGRP, S_IXOTH.

Confirmed that cross building a mingw gdb still works, and also made
sure it was gnulib's sys/stat.h that was defining the values, by
hacking the header with #errors where the macros are defined.

gdb/
2013-12-02  Pedro Alves  <palves@redhat.com>

	* ctf.c (ctf_start): Use S_IRGRP, S_IXGRP, S_IXOTH
	unconditionally.
This commit is contained in:
Pedro Alves 2013-12-02 11:09:24 +00:00
parent 0fdf84ca4b
commit 840207d8ee
2 changed files with 6 additions and 12 deletions

View File

@ -1,3 +1,8 @@
2013-12-02 Pedro Alves <palves@redhat.com>
* ctf.c (ctf_start): Use S_IRGRP, S_IXGRP, S_IXOTH
unconditionally.
2013-12-02 Pedro Alves <pedro@codesourcery.com>
Maciej W. Rozycki <macro@codesourcery.com>

View File

@ -313,18 +313,7 @@ ctf_start (struct trace_file_writer *self, const char *dirname)
struct ctf_trace_file_writer *writer
= (struct ctf_trace_file_writer *) self;
int i;
mode_t hmode = S_IRUSR | S_IWUSR | S_IXUSR
#ifdef S_IRGRP
| S_IRGRP
#endif
#ifdef S_IXGRP
| S_IXGRP
#endif
| S_IROTH
#ifdef S_IXOTH
| S_IXOTH
#endif
;
mode_t hmode = S_IRUSR | S_IWUSR | S_IXUSR | S_IRGRP | S_IXGRP | S_IROTH;
/* Create DIRNAME. */
if (mkdir (dirname, hmode) && errno != EEXIST)