OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove some GDB specific stuff from selftest.c 

The next patch moves selftest.c to common/selftest.c, so that GDBserver
can use it as well.  However selftest.c uses something isn't "portable" on
GDB and GDBserver.

First, this patch removes QUIT.  I don't expect that we type ctrl-c during
self/unit tests, and each test shouldn't take long time.  Secondly, I
replace exception_fprintf and printf_filtered with debug_printf.  Verified
that unit tests still catch fails.

gdb:

2017-08-18  Yao Qi  <yao.qi@linaro.org>

	* selftest.c (run_tests): Don't call QUIT.  Call debug_printf
	instead of exception_fprintf and printf_filtered.
This commit is contained in:
Yao Qi 2017-08-18 09:20:43 +01:00
parent 7649770c8e
commit 86dcbf50fe
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2017-08-18 Yao Qi <yao.qi@linaro.org>
* selftest.c (run_tests): Don't call QUIT. Call debug_printf
instead of exception_fprintf and printf_filtered.
2017-08-18 Yao Qi <yao.qi@linaro.org>
* selftest.c (register_self_test): Rename it to

8
gdb/selftest.c
View File

@ -44,8 +44,6 @@ run_tests (void)
for (int i = 0; i < tests.size (); ++i)
{
QUIT;
TRY
{
tests[i] ();
@ -53,7 +51,7 @@ run_tests (void)
CATCH (ex, RETURN_MASK_ERROR)
{
++failed;
exception_fprintf (gdb_stderr, ex, _("Self test failed: "));
debug_printf ("Self test failed: %s\n", ex.message);
}
END_CATCH
@ -62,7 +60,7 @@ run_tests (void)
reinit_frame_cache ();
}
printf_filtered (_("Ran %lu unit tests, %d failed\n"),
(long) tests.size (), failed);
debug_printf ("Ran %lu unit tests, %d failed\n",
(long) tests.size (), failed);
}
} // namespace selftests