OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

record-full: Remove unused function netorder16 

clang shows this warning:

  /home/emaisin/src/binutils-gdb/gdb/record-full.c:2344:1: error: unused function 'netorder16' [-Werror,-Wunused-function]
  netorder16 (uint16_t input)
  ^

Remove this function, which, AFAIK, has never been used.  Note that GCC
doesn't warn about this, because the function is marked as inline.
According to gcc's man page, it should ideed not warn:

  -Wunused-function
    Warn whenever a static function is declared but not defined or a non-inline static function is unused.  This warning is enabled by -Wall.

So it's probably not a GCC bug that it doesn't find this unused function, but a
different definition of "unused".

gdb/ChangeLog:

	* record-full.c (netorder16): Remove.
This commit is contained in:
Simon Marchi 2017-06-26 15:08:36 +02:00
parent 8b5a7a6e8c
commit 873c08142c
2 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ChangeLog
View File

@ -1,3 +1,7 @@
2017-06-26 Simon Marchi <simon.marchi@ericsson.com>
* record-full.c (netorder16): Remove.
2017-06-26 Simon Marchi <simon.marchi@ericsson.com>
* common/diagnostics.h: Define macros for GCC.

10
gdb/record-full.c
View File

@ -2340,16 +2340,6 @@ netorder32 (uint32_t input)
return ret;
}
static inline uint16_t
netorder16 (uint16_t input)
{
uint16_t ret;
store_unsigned_integer ((gdb_byte *) &ret, sizeof (ret),
BFD_ENDIAN_BIG, input);
return ret;
}
/* Restore the execution log from a core_bfd file. */
static void
record_full_restore (void)